bugfix(android): Allow Volume* keys to be passed to the user
#3636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
38 tasks
madsmtm
approved these changes
Apr 18, 2024
msiglreith
approved these changes
Apr 18, 2024
|
Took me a while to see, but yes this should allow the users to react to input 👍 Thanks for the fix! |
MarijnS95
force-pushed
the
android-fix-volume-keys
branch
from
eb6ddb7 to
789063f
Compare
kchibisov
approved these changes
Apr 22, 2024
It seems that discussions around rust-windowing#2748 being a poor workaround that should rather be implemented properly/differently drowned out the fact that the workaround was implemented incorrectly to begin with. By having the `if` inside the match arm, rather than /on/ the match arm the `keycode =>` path is /never/ used for `Volume*` keys and this event is thus never passed on to the user, defeating the purpose of calling `handle_volume_keys()`. Only the `Handled`/`Unhandled` state is affected by the `ignore_volume_keys` workaround, as set by `EventLoopBuilderExtAndroid::handle_volume_keys()`. Fix this by moving the `if` workaround on the match arm, so that disabling it via `EventLoopBuilderExtAndroid::handle_volume_keys()` causes `Volume*` events to be delivered to user code once again.
MarijnS95
force-pushed
the
android-fix-volume-keys
branch
from
15bea12 to
28034a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that discussions around #2748 (cc @Hoodad) being a poor workaround that should rather be implemented properly/differently drowned out the fact that the workaround was implemented incorrectly to begin with. By having the
ifinside the match arm, rather than /on/ the match arm thekeycode =>path is /never/ used forVolume*keys and this event is thus never passed on to the user, defeating the purpose of callinghandle_volume_keys(). Only theHandled/Unhandledstate is affected by theignore_volume_keysworkaround, as set byEventLoopBuilderExtAndroid::handle_volume_keys().Fix this by moving the
ifworkaround on the match arm, so that disabling it viaEventLoopBuilderExtAndroid::handle_volume_keys()causesVolume*events to be delivered to user code once again.changelogmodule if knowledge of this change could be valuable to users