-
Notifications
You must be signed in to change notification settings - Fork 933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to enable/disable WS_CLIPCHILDREN
window style
#3212
Add option to enable/disable WS_CLIPCHILDREN
window style
#3212
Conversation
While working on tauri-apps/wry#1041 which allows adding the webview as a child window, I noticed that when setting the webview to be transparent, the portion of the parent behind it doesn't render properly and that was because of `WS_CLIPCHILDREN`
Why was |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will break child rendering in non-special cases. The parent window can now overdraw the child window.
Would it make more sense to make this configurable? and what should the default behavior be? |
I would prefer to avoid adding a config for this as it just increases the api surface - I can try to look a bit at the weekend if there is a better solution, atm unsure how alpha blended composition is done in detail here to achieve the desired effect |
After trying various options1, getting the compositor to alpha blend a child window is quite a challenge.. unsure if it's possible in a generalized way. Therefore I'm currently leaning towards a backend specific option to disable certain style flags. Footnotes
|
If that will be the resolution, I'd probably suggest to put this thing on hold, until better days/0.30.0. |
I will add that once I get some time, but should |
Thanks, |
alright, should be good to go now. |
WS_CLIPCHILDREN
from window styleWS_CLIPCHILDREN
window style
While working on tauri-apps/wry#1041 which allows adding the webview as a child window, I noticed that when setting the webview to be transparent, the portion of the parent behind it doesn't render properly and that was because of
WS_CLIPCHILDREN
CHANGELOG.md
if knowledge of this change could be valuable to users