Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial solution for issue #240 #246

Closed
wants to merge 2 commits into from
Closed

Partial solution for issue #240 #246

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Jul 28, 2017

I don't have mac or linux at hand, so only the windows version was tested.
For mac and x11/wayland just some ad-hoc solution is provided, please check its correctness.

@tomaka
Copy link
Contributor

tomaka commented Jul 28, 2017

That's the wrong fix in my opinion.
Instead WM_CLOSE should simply send a Closed event, while WM_DESTROY doesn't send any event.

@ghost
Copy link
Author

ghost commented Jul 28, 2017

That was my original guess, but had no idea if WM_DESTROY was selected for some concrete reason.
Than the fix is just a single word replace of WM_DESTROY to WM_CLOSE

@ghost
Copy link
Author

ghost commented Jul 28, 2017

another PR is opened with the suggested change:
#247

@ghost ghost closed this Jul 28, 2017
@ghost ghost deleted the issue_240 branch August 1, 2017 07:56
tmfink pushed a commit to tmfink/winit that referenced this pull request Jan 5, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant