Reduce duplication in dpi module
#2148
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsmtm
added
C - waiting on maintainer
amrbashir
added a commit
to tauri-apps/tao
that referenced
this pull request
Jul 7, 2023
13 tasks
amrbashir
added a commit
to tauri-apps/tao
that referenced
this pull request
Jul 11, 2023
* feat: split min/max size constraints, closes #138 * windows impl * linux impl * fix linux impl * cleanup linux impl * macOS impl * imports * ios build * macos build * unsafe * merge `set_min/max_width/height` into a single function * fix macos build * macos again * use macros to generate DPI types ref: rust-windowing/winit#2148 * fix windows impl * fmt
5 tasks
madsmtm
force-pushed
the
dpi-reduce-duplication
branch
from
5e156de to
e0f0f04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Grabbed from #1374. The motivation in here was to add a
Deltavariant of these (as part of a replacement ofMouseScrollDelta).The only API changes in this PR is the
PartialOrd/Ordimpls, as noted in the changelog, the rest is merely a code-reduction that I believe is valuable (makes it much easier to see what's different betweenSizeandPosition).Tagging original author @Osspial.
CHANGELOG.mdif knowledge of this change could be valuable to users