Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

winit incorrectly assumes xdg_surface.configure event always arrive in one roundtrip. #2560

Closed
yshui opened this issue Nov 18, 2022 · 0 comments · Fixed by #2676
Closed

winit incorrectly assumes xdg_surface.configure event always arrive in one roundtrip. #2560

yshui opened this issue Nov 18, 2022 · 0 comments · Fixed by #2676

Comments

@yshui
Copy link

yshui commented Nov 18, 2022

The spec does not make that guarantee, and states the client is not allowed to attach a buffer until a configure event is received. However winit would start attaching buffers anyway after one roundtrip, whether a configure is received or not.

I only find this out because I have a not-fully-implemented compositor. I assume most of the existing compositors would send out configure immediately.

@kchibisov kchibisov added this to the Version 0.28 milestone Nov 20, 2022
@kchibisov kchibisov modified the milestones: Version 0.28, Version 0.29.0 Feb 2, 2023
kchibisov added a commit to kchibisov/winit that referenced this issue Feb 4, 2023
This update rewrites the winit's Wayland backend using new wayland-rs
0.30 API. This fixes long standing issue with the forward compatibility
of the wayland backend, meaning that future updates to the wayland
protocol won't break rust code anymore. like it was before when adding
new shm/enum variants into the protocol.

Fixes rust-windowing#2560.
Fixes rust-windowing#2128.
kchibisov added a commit to kchibisov/winit that referenced this issue Feb 6, 2023
This update rewrites the winit's Wayland backend using new wayland-rs
0.30 API. This fixes long standing issue with the forward compatibility
of the wayland backend, meaning that future updates to the wayland
protocol won't break rust code anymore. like it was before when adding
new shm/enum variants into the protocol.

Fixes rust-windowing#2560.
Fixes rust-windowing#2128.
kchibisov added a commit to kchibisov/winit that referenced this issue Feb 6, 2023
This update rewrites the winit's Wayland backend using new wayland-rs
0.30 API. This fixes long standing issue with the forward compatibility
of the wayland backend, meaning that future updates to the wayland
protocol won't break rust code anymore. like it was before when adding
new shm/enum variants into the protocol.

Fixes rust-windowing#2560.
Fixes rust-windowing#2128.
kchibisov added a commit to kchibisov/winit that referenced this issue Feb 24, 2023
This update rewrites the winit's Wayland backend using new wayland-rs
0.30 API. This fixes long standing issue with the forward compatibility
of the wayland backend, meaning that future updates to the wayland
protocol won't break rust code anymore. like it was before when adding
new shm/enum variants into the protocol.

Fixes rust-windowing#2560.
Fixes rust-windowing#2128.
kchibisov added a commit to kchibisov/winit that referenced this issue Feb 25, 2023
This update rewrites the winit's Wayland backend using new wayland-rs
0.30 API. This fixes long standing issue with the forward compatibility
of the wayland backend, meaning that future updates to the wayland
protocol won't break rust code anymore. like it was before when adding
new shm/enum variants into the protocol.

Fixes rust-windowing#2560.
Fixes rust-windowing#2128.
kchibisov added a commit to kchibisov/winit that referenced this issue Mar 6, 2023
This update rewrites the winit's Wayland backend using new wayland-rs
0.30 API. This fixes long standing issue with the forward compatibility
of the wayland backend, meaning that future updates to the wayland
protocol won't break rust code anymore. like it was before when adding
new shm/enum variants into the protocol.

Fixes rust-windowing#2560.
Fixes rust-windowing#2164.
Fixes rust-windowing#2128.
Fixes rust-windowing#1760.
Fixes rust-windowing#725.
kchibisov added a commit to kchibisov/winit that referenced this issue Mar 8, 2023
This update rewrites the winit's Wayland backend using new wayland-rs
0.30 API. This fixes long standing issue with the forward compatibility
of the wayland backend, meaning that future updates to the wayland
protocol won't break rust code anymore. like it was before when adding
new shm/enum variants into the protocol.

Fixes rust-windowing#2560.
Fixes rust-windowing#2164.
Fixes rust-windowing#2128.
Fixes rust-windowing#1760.
Fixes rust-windowing#725.
kchibisov added a commit to kchibisov/winit that referenced this issue Apr 1, 2023
This update rewrites the winit's Wayland backend using new wayland-rs
0.30 API. This fixes long standing issue with the forward compatibility
of the wayland backend, meaning that future updates to the wayland
protocol won't break rust code anymore. like it was before when adding
new shm/enum variants into the protocol.

Fixes rust-windowing#2560.
Fixes rust-windowing#2164.
Fixes rust-windowing#2128.
Fixes rust-windowing#1760.
Fixes rust-windowing#725.
kchibisov added a commit to kchibisov/winit that referenced this issue Apr 18, 2023
This update rewrites the winit's Wayland backend using new wayland-rs
0.30 API. This fixes long standing issue with the forward compatibility
of the wayland backend, meaning that future updates to the wayland
protocol won't break rust code anymore. like it was before when adding
new shm/enum variants into the protocol.

Fixes rust-windowing#2560.
Fixes rust-windowing#2164.
Fixes rust-windowing#2128.
Fixes rust-windowing#1760.
Fixes rust-windowing#725.
kchibisov added a commit to kchibisov/winit that referenced this issue Apr 18, 2023
This update rewrites the winit's Wayland backend using new wayland-rs
0.30 API. This fixes long standing issue with the forward compatibility
of the wayland backend, meaning that future updates to the wayland
protocol won't break rust code anymore. like it was before when adding
new shm/enum variants into the protocol.

Fixes rust-windowing#2560.
Fixes rust-windowing#2164.
Fixes rust-windowing#2128.
Fixes rust-windowing#1760.
Fixes rust-windowing#725.
kchibisov added a commit to kchibisov/winit that referenced this issue Apr 18, 2023
This update rewrites the winit's Wayland backend using new wayland-rs
0.30 API. This fixes long standing issue with the forward compatibility
of the wayland backend, meaning that future updates to the wayland
protocol won't break rust code anymore. like it was before when adding
new shm/enum variants into the protocol.

Fixes rust-windowing#2560.
Fixes rust-windowing#2164.
Fixes rust-windowing#2128.
Fixes rust-windowing#1760.
Fixes rust-windowing#725.
kchibisov added a commit to kchibisov/winit that referenced this issue Apr 18, 2023
This update rewrites the winit's Wayland backend using new wayland-rs
0.30 API. This fixes long standing issue with the forward compatibility
of the wayland backend, meaning that future updates to the wayland
protocol won't break rust code anymore. like it was before when adding
new shm/enum variants into the protocol.

Fixes rust-windowing#2560.
Fixes rust-windowing#2164.
Fixes rust-windowing#2128.
Fixes rust-windowing#1760.
Fixes rust-windowing#725.
kchibisov added a commit that referenced this issue Apr 18, 2023
This update rewrites the winit's Wayland backend using new wayland-rs
0.30 API. This fixes long standing issue with the forward compatibility
of the wayland backend, meaning that future updates to the wayland
protocol won't break rust code anymore. like it was before when adding
new shm/enum variants into the protocol.

Fixes #2560.
Fixes #2164.
Fixes #2128.
Fixes #1760.
Fixes #725.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

3 participants