Adds context sharing support for the X11 & Wayland backends #1045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goddessfreya
force-pushed
the
share-contexes
branch
from
d2b84ce to
4f119fe
Compare
|
Oh, I've implemented context sharing for the X11 today. I looked here after (bad luck). My change is much simpler (and it isn't API breaking) but I believe it's because I do not support Wayland. I think it makes no sense to create pull request now, but if someone wants to look, it's here: |
|
@marek-g From a cursory glance, your changes won't work with X11 + egl. My PR implements context sharing for X11 + Egl/Glx & Wayland in 54 line additions. |
|
@zegentzy You may be right. I've only tested it with X11/GLX. I can't wait for your changes to be merged :) |
goddessfreya
force-pushed
the
share-contexes
branch
from
4f119fe to
0b9b653
Compare
20 tasks
goddessfreya
force-pushed
the
share-contexes
branch
8 times, most recently
from
42e03c3 to
a76127b
Compare
goddessfreya
force-pushed
the
share-contexes
branch
2 times, most recently
from
7cd8dd9 to
72af1ec
Compare
Signed-off-by: Hal Gentz <[email protected]>
Signed-off-by: Hal Gentz <[email protected]>
Signed-off-by: Hal Gentz <[email protected]>
non-`shareable_with_windowed_contexts` fallback to being shareable if unsupported. Updated docs. Signed-off-by: Hal Gentz <[email protected]>
Signed-off-by: Hal Gentz <[email protected]>
goddessfreya
force-pushed
the
share-contexes
branch
from
72af1ec to
ae73fd2
Compare
Signed-off-by: Hal Gentz <[email protected]>
goddessfreya
force-pushed
the
share-contexes
branch
from
ae73fd2 to
c89e0e9
Compare
Signed-off-by: Hal Gentz <[email protected]>
goddessfreya
force-pushed
the
share-contexes
branch
from
c89e0e9 to
e7833d9
Compare
Signed-off-by: Hal Gentz <[email protected]>
goddessfreya
force-pushed
the
share-contexes
branch
from
e7833d9 to
306aa6e
Compare
1 task
Signed-off-by: Hal Gentz <[email protected]>
Signed-off-by: Hal Gentz <[email protected]>
goddessfreya
force-pushed
the
share-contexes
branch
from
306aa6e to
26fe315
Compare
|
Merged with #1058 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: rust-windowing/winit#572 #1029
Now both backends support shared contexts, however the wayland backend requires that shared contexts are made with the same events loop.
Signed-off-by: Hal Gentz [email protected]