Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gpio/update #256

Merged
merged 3 commits into from
Dec 5, 2022
Merged

Gpio/update #256

merged 3 commits into from
Dec 5, 2022

Conversation

vireshk
Copy link
Collaborator

@vireshk vireshk commented Nov 29, 2022 

gpiod: Migrate to upstreamed version of libgpiod

The libgpiod rust bindings got upstreamed recently. Migrate to the
upstreamed version.

@vireshk
Copy link
Collaborator Author

vireshk commented Nov 29, 2022

@andreeaflorescu Some issues with builds here, timing out, any idea ?

@vireshk vireshk enabled auto-merge (rebase) November 29, 2022 11:36
@andreeaflorescu
Copy link
Member

There seems to be some problem with the hosts on which we run the CIs and the first jobs that run will always timeout because they wait for the container to download. Even if the container is downloaded though the jobs take significantly longer to execute. @aghecenco did an initial investigation and it seems like all the threads are busy with epoll for some reason. We don't have a lot more details now, but we will prioritize this to find a fix. In the meantime, you can just retrigger the job and it should pass. This is not ideal, we'll keep you posted related to the fix.

@andreeaflorescu
Copy link
Member

There is a legit failure from cargo audit. We should open an issue to track that.

@alxiord
Copy link
Member

alxiord commented Nov 29, 2022

There is a legit failure from cargo audit. We should open an issue to track that.

See rust-vmm/rust-vmm-ci#114 for the audit failure.

@vireshk vireshk disabled auto-merge November 30, 2022 06:38
@vireshk vireshk enabled auto-merge (rebase) November 30, 2022 06:38
@vireshk
Copy link
Collaborator Author

vireshk commented Nov 30, 2022

In the meantime, you can just retrigger the job and it should pass. This is not ideal, we'll keep you posted related to the fix.

Tried. Still not passing.

@andreeaflorescu
Copy link
Member

We're tracking the timeout issue here: rust-vmm/community#137

@vireshk vireshk force-pushed the gpio/update branch 2 times, most recently from 616e975 to 64a7e5d Compare December 1, 2022 02:29
@vireshk
gpio: Remove get_ prefix for getters
24a69cd 
The Rust language guidelines suggests not prefixing getters with get_.
Remove the same from GPIO getters.

https://rust-lang.github.io/api-guidelines/naming.html

Signed-off-by: Viresh Kumar <[email protected]>
@vireshk
gpiod: Migrate to upstreamed version of libgpiod
daa02ac 
The libgpiod rust bindings got upstreamed recently. Migrate to the
upstreamed version.

Signed-off-by: Viresh Kumar <[email protected]>
@vireshk vireshk requested a review from stsquad December 1, 2022 11:23
@vireshk
Copy link
Collaborator Author

vireshk commented Dec 2, 2022

@stefano-garzarella @mathieupoirier

Can someone please review this ?

@vireshk vireshk merged commit 7c1d5ac into rust-vmm:main Dec 5, 2022
@vireshk vireshk deleted the gpio/update branch December 22, 2022 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stsquad stsquad stsquad approved these changes

@stefano-garzarella stefano-garzarella stefano-garzarella approved these changes

@mathieupoirier mathieupoirier Awaiting requested review from mathieupoirier

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vireshk @andreeaflorescu @alxiord @stsquad @stefano-garzarella