Reduce technical debt & increase timeout #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreeaflorescu
requested review from
gsserge,
lauralt and
sameo
as code owners
We were using a rather outdated version. Moving to the latest available one. Signed-off-by: Andreea Florescu <[email protected]>
andreeaflorescu
force-pushed
the
tech_debt
branch
2 times, most recently
from
ca00a9f to
823dbbb
Compare
|
Another thing that I want to do before merging this is to publish a new container version to update the base image from Ubuntu 18.04 to ubuntu 22. |
andreeaflorescu
force-pushed
the
tech_debt
branch
from
823dbbb to
d231355
Compare
This will take longer than anticipated, so I would propose just merging this once we get the hosts in order as well. |
By default we are now using the kvm hypervisor in tests. This can be overritten for the entire pipeline at the pipeline level by using the environment variable `AGENT_TAG_HYPERVISOR`. Fixes: rust-vmm#115 Signed-off-by: Andreea Florescu <[email protected]>
We need to increase the timeout for each test to 15 minutes because we are experiencing timeouts when running the tests. I think this might be actually related to the hosts running the CI, because some early investigations by [email protected] show that the threads are blocked on doing epoll_wait. This is odly similar to the issue discussed here related to epoll: https://lore.kernel.org/all/[email protected]/ For more details, check: rust-vmm/community#137 Signed-off-by: Andreea Florescu <[email protected]>
andreeaflorescu
force-pushed
the
tech_debt
branch
from
d231355 to
dbb2e7f
Compare
andreeaflorescu
changed the title
jiangliu
approved these changes
Nov 30, 2022
lauralt
approved these changes
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
We were using a rather outdated version. Moving to the latest available one.
There are some other things that need fixing and I am looking at addressing in this PR, hence for now this is WIP.
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commitmessage has max 60 characters for the summary and max 75 characters for each
description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.