Deny warnings #47
- Loading branch information
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -88,14 +88,14 @@ In addition, the following `allow`ed lints may be a good idea to `deny`: | |
| unused-results)] | ||
| ``` | ||
|
|
||
| Note that we explicitly did not set the [deprecate attribute] | ||
|
There was a problem hiding this comment. Nit: there should be a period at the end of this sentence |
||
|
|
||
|
There was a problem hiding this comment. I would add some discussion around the fact that usually in Rust, we recommend using in-crate attributes rather than command line flags (several reasons for this, starting with ensuring consistent build experiences without needing a build script on top of Cargo or whatever). However, the advice here is an exception to that rule and maybe explain why it makes sense (which I guess comes down to, deny(warnings) whould be a personal part of the build experience, not something you force onto your clients). It is probably worth stating the alternative of denying specific warnings as attributes which does not have the behaviour you describe. There was a problem hiding this comment.
Is this true in general? Even when only specific warnings are chosen, the meanings of the warnings themselves can change over time. That was part of the motivation for rust-lang/rfcs#1193, after all. There was a problem hiding this comment. I would guess it would be 99% true. Warnings very rarely change their meaning. Though they might expand slightly, it is usually to cover edge cases and is unlikely to cause breakage. I expect that any problems this causes is more than outweighed by the benefits of catching errors earlier in the development process and without needing a custom script to run the builds. ISTM that the hazard of the lint case is another lint silently appearing and this approach does not have that problem. There was a problem hiding this comment. All right. I think the list of lints is now complete and usable. |
||
| ## See also | ||
|
|
||
| - [deprecate attribute] documentation | ||
| - Type `rustc -W help` for a list of lints on your system. Also type | ||
| `rustc --help` for a general list of options | ||
| - [rust-clippy] is a collection of lints for better Rust code | ||
|
|
||
| [rust-clippy]: https://github.com/Manishearth/rust-clippy | ||
| [deprecate attribute]: https://doc.rust-lang.org/reference.html#miscellaneous-attributes | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd add
missing-debug-implementations(and maybemissing-copy-implementations, though that's perhaps more controversial).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.