rand_distr: fix no_std build #1208
Conversation
| @@ -13,6 +13,8 @@ use crate::{Distribution, Uniform}; | |||
| use rand::Rng; | |||
| use core::fmt; | |||
| use core::cmp::Ordering; | |||
| #[allow(unused_imports)] | |||
| use num_traits::Float; | |||
There was a problem hiding this comment.
The allow attributes is a bit unfortunate, but we currently don't have a way of checking whether std is enabled for current build, note that it's not equivalent to checking feature = "std".
|
I believe we can add |
|
IIRC it's not true for Rust 1.36. |
|
In that case it sounds like the best thing to do is release a patch now to fix this, then bump the MSRV for |
|
@newpavlov I'm using it here, and it seems to work for Rust 1.36. |
|
|
|
@dhardy I'll take care of the release tonight, unless you get to it before then. |
|
Published |
Closes #1205.
Note that the
test-no-stdjob checks onlyrandandrand_coreand does not affectrand_distrand other crates . IIUC we need a virtual manifest for it to work, not the current repository structure.Changing working directory to
rand_distrand runningcargo buildin it will not work due to the dev feature unification, i.e. we would needresolver = "2"forno_stdtests to work in that case.