Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable non blocking capture using selectable fd #78

Closed
wants to merge 1 commit into from
Closed

enable non blocking capture using selectable fd #78

wants to merge 1 commit into from

Conversation

lrbalt
Copy link
Contributor

@lrbalt lrbalt commented Jul 29, 2017

this pull enables set_nonblock and get_selectable_fd so you can capture packets in an event loop

I have an example to use this using tokio. I'll put that in a separate pull request

@lrbalt
Copy link
Contributor Author

lrbalt commented Jul 29, 2017

sorry, I missed #76. I think this one differs from #76 only on error handling in get_selectable_fd

@lrbalt
Copy link
Contributor Author

lrbalt commented Jul 30, 2017

failures are because of clippy not compiling on nightly

@ebfull
Copy link
Collaborator

ebfull commented Aug 4, 2017

It looks like #76 contained everything from this PR as well, so this PR can be closed?

@lrbalt
Copy link
Contributor Author

lrbalt commented Aug 5, 2017

Well, the error handling of get_selectable_fd differs from #76. And this enables the raw api methods ahead of #76 so you can use it now.

So I'd suggest to either adjust error handling on #76 or merge this one and rebate #76 on it.

@lrbalt
Copy link
Contributor Author

lrbalt commented Aug 5, 2017

Closing because #76 was merged

@lrbalt lrbalt closed this Aug 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lrbalt @ebfull