Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PAGE_SIZE constant and update MemoryProtection protocol docs #645

Merged
merged 3 commits into from
Jan 31, 2023
Merged

Add PAGE_SIZE constant and update MemoryProtection protocol docs #645

merged 3 commits into from
Jan 31, 2023

Conversation

nicholasbishop
Copy link
Member

Checklist

  • Sensible git history (for example, squash "typo" or "fix" commits). See the Rewriting History guide for help.
  • Update the changelog (if necessary)

@nicholasbishop
uefi: Add PAGE_SIZE constant
a01b000 
The UEFI page size is always 4KiB (see `EFI_BOOT_SERVICES.AllocatePages` in the
spec).
@nicholasbishop
uefi: Update MemoryProtection protocol docs
253d5da 
- Drop reference to the proposal for this protocol, as of UEFI 2.10 it's in the
  official spec.
- Mention the C type for ease of searching the spec.
- Update the method docs to note that implementations typically require that the
  memory region is page-aligned. This isn't mentioned in the spec.
@nicholasbishop
Copy link
Member Author

CI issue should be fixed here: #646

@phip1611 phip1611 merged commit 83c5e8b into rust-osdev:main Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicholasbishop @phip1611