CI is broken with current nightly (2022-03-30) #397

nicholasbishop · 2022-03-31T20:19:13Z

The nightly compiler is crashing on something in fatfs. This dep is only used in xtask, so shouldn't affect compilation of uefi-rs itself.

I've filed a Rust bug for this: rust-lang/rust#95538

The text was updated successfully, but these errors were encountered:

The nightly rust compiler is currently unable to compile the version of fatfs we are using in xtask. Rust bug: rust-lang/rust#95538. But we don't need to use nightly to compile xtask. In the CI, install both stable and nightly toolchains. The stable toolchain will be used by default, and xtask already knows to insert `+nightly` when building uefi-rs, so there's no need to set `override: true` for the nightly toolchain anymore. Fixes #397

The xtask tests don't need to use the nightly toolchain or have any features set. Partially fixes #397

The nightly rust compiler is currently unable to compile the version of fatfs we are using in xtask. Rust bug: rust-lang/rust#95538. But we don't need to use nightly to compile xtask. In the CI, install both stable and nightly toolchains. The stable toolchain will be used by default, and xtask already knows to insert `+nightly` when building uefi-rs, so there's no need to set `override: true` for the nightly toolchain anymore. Fixes #397

The xtask tests don't need to use the nightly toolchain or have any features set. Partially fixes #397

The nightly rust compiler is currently unable to compile the version of fatfs we are using in xtask. Rust bug: rust-lang/rust#95538. But we don't need to use nightly to compile xtask. In the CI, install both stable and nightly toolchains. The stable toolchain will be used by default, and xtask already knows to insert `+nightly` when building uefi-rs, so there's no need to set `override: true` for the nightly toolchain anymore. Fixes #397

Add a `rust-toolchain.toml` file that specifies the channel and components needed to build uefi-rs. See https://rust-lang.github.io/rustup/overrides.html#the-toolchain-file for documentation of the `rust-toolchain.toml` format. Remove the `--toolchain` option from `xtask`, as using this file is a simpler alternative. Also remove the instructions for installing the nightly toolchain from the readme, as `rustup` will do this automatically now. The `toolchain` action used in the CI will pick up on this file as well, so removed all the sections spelling out the toolchain and components. Note that this change will also cause `xtask` itself to be built with nightly. That should generally be fine, we only had it using stable because of rust-osdev#397, and in the future we can easily temporarily pin to a non-current nightly if a bug occurs with an `xtask` dependency again. Fixes rust-osdev#498

Add a `rust-toolchain.toml` file that specifies the channel and components needed to build uefi-rs. See https://rust-lang.github.io/rustup/overrides.html#the-toolchain-file for documentation of the `rust-toolchain.toml` format. Remove the `--toolchain` option from `xtask`, as using this file is a simpler alternative. Also remove the instructions for installing the nightly toolchain from the readme, as `rustup` will do this automatically now. The `toolchain` action previously used in the CI is unmaintained and doesn't understand `rust-toolchain.toml` (it does understand the older `rust-toolchain` file, but that doesn't allow for including required components). Since the runners come with rustup already installed, we don't actually need a complex action here anyway, so just remove those sections entirely. Note that this change will also cause `xtask` itself to be built with nightly. That should generally be fine, we only had it using stable because of rust-osdev#397, and in the future we can easily temporarily pin to a non-current nightly if a bug occurs with an `xtask` dependency again. Fixes rust-osdev#498

Add a `rust-toolchain.toml` file that specifies the channel and components needed to build uefi-rs. See https://rust-lang.github.io/rustup/overrides.html#the-toolchain-file for documentation of the `rust-toolchain.toml` format. Remove the `--toolchain` option from `xtask`, as using this file is a simpler alternative. Also remove the instructions for installing the nightly toolchain from the readme, as `rustup` will do this automatically now. The template application has been updated to add a `rust-toolchain.toml`, and `BUILDING.md` has been updated to mention it as well. The `toolchain` action previously used in the CI is unmaintained and doesn't understand `rust-toolchain.toml` (it does understand the older `rust-toolchain` file, but that doesn't allow for including required components). Since the runners come with rustup already installed, we don't actually need a complex action here anyway, so just remove those sections entirely. Note that this change will also cause `xtask` itself to be built with nightly. That should generally be fine, we only had it using stable because of rust-osdev#397, and in the future we can easily temporarily pin to a non-current nightly if a bug occurs with an `xtask` dependency again. Fixes rust-osdev#498

Add a `rust-toolchain.toml` file that specifies the channel and components needed to build uefi-rs. See https://rust-lang.github.io/rustup/overrides.html#the-toolchain-file for documentation of the `rust-toolchain.toml` format. Remove the `--toolchain` option from `xtask`, as using this file is a simpler alternative. Also remove the instructions for installing the nightly toolchain from the readme, as `rustup` will do this automatically now. The template application has been updated to add a `rust-toolchain.toml`, and `BUILDING.md` has been updated to mention it as well. The `toolchain` action previously used in the CI is unmaintained and doesn't understand `rust-toolchain.toml` (it does understand the older `rust-toolchain` file, but that doesn't allow for including required components). Since the runners come with rustup already installed, we don't actually need a complex action here anyway, so just remove those sections entirely. A few jobs need extra components installed, do that with `rustup component add`. Note that this change will also cause `xtask` itself to be built with nightly. That should generally be fine, we only had it using stable because of rust-osdev#397, and in the future we can easily temporarily pin to a non-current nightly if a bug occurs with an `xtask` dependency again. Fixes rust-osdev#498

Add a `rust-toolchain.toml` file that specifies the channel and components needed to build uefi-rs. See https://rust-lang.github.io/rustup/overrides.html#the-toolchain-file for documentation of the `rust-toolchain.toml` format. Remove the `--toolchain` option from `xtask`, as using this file is a simpler alternative. Also remove the instructions for installing the nightly toolchain from the readme, as `rustup` will do this automatically now. The template application has been updated to add a `rust-toolchain.toml`, and `BUILDING.md` has been updated to mention it as well. The `toolchain` action previously used in the CI is unmaintained and doesn't understand `rust-toolchain.toml` (it does understand the older `rust-toolchain` file, but that doesn't allow for including required components). Since the runners come with rustup already installed, we don't actually need a complex action here anyway, so just remove those sections entirely. A few jobs need extra components installed, do that with `rustup component add`. Note that this change will also cause `xtask` itself to be built with nightly. That should generally be fine, we only had it using stable because of #397, and in the future we can easily temporarily pin to a non-current nightly if a bug occurs with an `xtask` dependency again. Fixes #498

GabrielMajeri mentioned this issue Apr 1, 2022

Add support to get the file path of loaded image #398

Merged

nicholasbishop mentioned this issue Apr 1, 2022

ci: use stable toolchain for compiling xtask #399

Merged

nicholasbishop added a commit that referenced this issue Apr 1, 2022

xtask: run xtask tests separately from uefi tests

334034b

The xtask tests don't need to use the nightly toolchain or have any features set. Partially fixes #397

nicholasbishop closed this as completed in #399 Apr 1, 2022

nicholasbishop added a commit that referenced this issue Apr 1, 2022

xtask: run xtask tests separately from uefi tests

20d98ad

The xtask tests don't need to use the nightly toolchain or have any features set. Partially fixes #397

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CI is broken with current nightly (2022-03-30) #397

CI is broken with current nightly (2022-03-30) #397

nicholasbishop commented Mar 31, 2022 •

edited

Loading

CI is broken with current nightly (2022-03-30) #397

CI is broken with current nightly (2022-03-30) #397

Comments

nicholasbishop commented Mar 31, 2022 • edited Loading

nicholasbishop commented Mar 31, 2022 •

edited

Loading