Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove nightly/stable features when Rust 1.61 is released #23

Closed
phil-opp opened this issue Mar 28, 2022 · 3 comments · Fixed by #24
Closed

Remove nightly/stable features when Rust 1.61 is released #23

phil-opp opened this issue Mar 28, 2022 · 3 comments · Fixed by #24

Comments

@phil-opp
Copy link
Member

The const_ptr_offset feature was stabilized in rust-lang/rust#93957. We removed that feature gate from this crate in #22. Right now, we still need the stable and nightly features of this crate to make MmioSerialPort::new a const function on nightly, but on Rust 1.61 this should be supported on stable as well. So we should remove the crate features when 1.61 is released.
@Hugo4IT
Copy link

Hugo4IT commented Apr 1, 2022

is there a temporary workaround for this, because right now I can't compile my stuff because of this.

@phil-opp
Copy link
Member Author

phil-opp commented Apr 1, 2022

@Hugo4IT This issue is just about removing some features of this crate in the future, it should not be releated to any breakage.

There was a recent breakage on the latest nightly that was fixed by #22. You can update to that fix by running cargo update -p uart_16550. If that doesn't fix your problem, please open a new issue with your exact compile error, and the rustc and uart_16550 versions that you're using.

@Hugo4IT
Copy link

Hugo4IT commented Apr 1, 2022

I see, I thought running cargo clean before running again would update everything (my dependency is uart_16550 = "0.2"). Thanks for your quick help, it works now.

josephlr added a commit to josephlr/uart_16550 that referenced this issue Apr 15, 2022
@josephlr
Remove use of stable and nightly features
0e78b70 
We can now use `rustversion` to mark `MmioSerialPort::new()` as const or
not depending on the rust version. The features can't be removed yet as
that would be a breaking change.

This removes code duplication and lets us avoid increasing our MSRV.

Fixes rust-osdev#23

Signed-off-by: Joe Richey <[email protected]>
@josephlr josephlr mentioned this issue Apr 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove use of stable and nightly features josephlr/uart_16550
2 participants
@phil-opp @Hugo4IT