Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document PrimInt #11

Closed
cuviper opened this issue Dec 19, 2017 · 1 comment
Closed

Document PrimInt #11

cuviper opened this issue Dec 19, 2017 · 1 comment
Labels
documentation help wanted

Comments

@cuviper
Copy link
Member

cuviper commented Dec 19, 2017

From @gnzlbg on December 17, 2015 12:10

It took me a bit to realize that PrimInt is the trait that provides the bit manipulation operations on primitive types (nothing more, nothing less). The methods are documented but the Trait itself is not documented.

Copied from original issue: rust-num/num#140
@cuviper
Copy link
Member Author

cuviper commented Dec 19, 2017

PrimInt corresponds to the unique methods of rust's old Int trait (removed in rust-lang/rust@eeb9488), with the methods that were already covered in traits like Zero and One now added by inheritance. Because of the broad inherited traits, it's not really "just" a bit-twiddling trait though, so it should be documented as being a generic primitives trait.

@cuviper cuviper mentioned this issue Dec 19, 2017
Closed
This was referenced Mar 14, 2019
Closed
Merged
bors bot added a commit that referenced this issue Mar 28, 2019
@bors @dvdhrm
Merge #108
4ab251b 
108: int: document PrimInt trait r=cuviper a=dvdhrm

This documents the PrimInt trait, explains its intentions and features
as well as mentions its origins for future reference.

Closes #11.

Co-authored-by: David Rheinsberg <[email protected]>
@bors bors bot closed this as completed in #108 Mar 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cuviper