Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify discriminant matching #10

Merged
merged 1 commit into from
Feb 10, 2018
Merged

Simplify discriminant matching #10

merged 1 commit into from
Feb 10, 2018

Conversation

cuviper
Copy link
Member

@cuviper cuviper commented Feb 10, 2018

We don't actually need to know the expressions assigned to each variant,
nor compute offsets for those without an expression. We can just cast
each #name::#ident directly to i64 for comparison.

@cuviper
Simplify discriminant matching
53f2b33 
We don't actually need to know the expressions assigned to each variant,
nor compute offsets for those without an expression.  We can just cast
each `#name::#ident` directly to `i64` for comparison.
@cuviper
Copy link
Member Author

cuviper commented Feb 10, 2018

bors r+

bors bot added a commit that referenced this pull request Feb 10, 2018
@bors
Merge #10
cb67715 
10: Simplify discriminant matching r=cuviper a=cuviper

We don't actually need to know the expressions assigned to each variant,
nor compute offsets for those without an expression.  We can just cast
each `#name::#ident` directly to `i64` for comparison.
@bors
Copy link
Contributor

bors bot commented Feb 10, 2018

Build succeeded

@bors bors bot merged commit 53f2b33 into rust-num:master Feb 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cuviper