adb: Use current date/time instead of last logcat line for timestamp
#213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have some phones, including the Vivo X90 Pro which return an empty string for `logcat -t 1`, resulting in an `unwrap()` crash before starting logging. There doesn't appear to be any reason to check the time of the latest **random** (not even `--uid`-scoped) message in `logcat` as we can just read the current date and time as well. We haven't started the app yet either way, and this timestamp is inevitably already going to be later than the most recent message. Also remove some unnecessary shell escaping (which should have been done by `shlex` otherwise) by calling `adb logcat` rather than `adb shell logcat`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have some phones, including the Vivo X90 Pro which return an empty string for
logcat -t 1, resulting in anunwrap()crash before starting logging. There doesn't appear to be any reason to check the time of the latest random (not even--uid-scoped) message inlogcatas we can just read the current date and time as well. We haven't started the app yet either way, and this timestamp is inevitably already going to be later than the most recent message.Also remove some unnecessary shell escaping (which should have been done by
shlexotherwise) by callingadb logcatrather thanadb shell logcat.