Skip to content
This repository has been archived by the owner on Apr 8, 2024. It is now read-only.

Make sure we reject everything in src/test/ui/parser/ #11

Open
Centril opened this issue Nov 1, 2018 · 3 comments
Open

Make sure we reject everything in src/test/ui/parser/ #11

Centril opened this issue Nov 1, 2018 · 3 comments

Comments

@Centril
Copy link
Contributor

Centril commented Nov 1, 2018

We'd like the grammar to reject everything inside https://github.com/rust-lang/rust/tree/master/src/test/ui/parser since those are parse-fail tests.

@eddyb
Copy link
Member

eddyb commented Nov 1, 2018

We might want to look for hints like // compile-flags: with -Z parse-only on the same line, accompanied by ERROR comments and/or a stderr file, instead of hardcoding a directory.

@Centril
Copy link
Contributor Author

Centril commented Nov 1, 2018

Yeah that might be more robust, but it also relies on -Z parse-only remaining the way in compile_test so you'll have to make sure that the rest of the compiler team don't sweep that out from under us without prior notice ;)

@petrochenkov
Copy link

All -Z parse-only are indeed in ui/parser currently, but ui/parser also contains compile-pass tests and some non--Z parse-only tests doing parsing-during-expansion, so #11 (comment) is certainly more robust.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants