-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LoongArch SIMD intrinsics #1535
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Amanieu (or someone else) some time within the next two weeks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the tests also automatically generated, or just the intrinsic definitions?
The tests are also automatically generated, but not by this generator. |
Can you also include the generator used for making the tests? I don't want to include any auto-generated code in this repo without also including the generator used to create it. Finally, can you also commit a copy of the header files used to generate the .spec files? |
Thanks for your review. I have updated the patch to include code for generating test cases and also added copying of header files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Just a few minor changes and this is good to merge.
Co-authored-by: WANG Rui <[email protected]>
Co-authored-by: WANG Rui <[email protected]>
Co-authored-by: ZHAI Xiang <[email protected]>
This PR adds LoongArch SIMD (LSX/LASX) intrinsics and testcases.