Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace remaining winapi usage with windows-sys #3802

Merged
merged 1 commit into from
May 6, 2024

Conversation

kennykerr
Copy link
Contributor

I noticed that the rustup project already started adopting the windows-sys crate. This update merely replaces the remaining direct dependencies on the older winapi crate with windows-sys.

Copy link
Member

@rami3l rami3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the cleanup! I'll merge this PR shortly after the v1.27.1 release.

@rami3l
Copy link
Member

rami3l commented May 2, 2024

@kennykerr One small thing: since we're using rebase merge, would you mind rewording the single commit in this patch? Reusing the PR title would be just fine :)

@kennykerr
Copy link
Contributor Author

@rami3l I've renamed the commit.

@rami3l rami3l mentioned this pull request May 6, 2024
1 task
@rami3l rami3l added this pull request to the merge queue May 6, 2024
@rami3l rami3l added this to the 1.28.0 milestone May 6, 2024
Merged via the queue into rust-lang:master with commit db55a2c May 6, 2024
22 checks passed
@rami3l rami3l mentioned this pull request Oct 6, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants