-
Notifications
You must be signed in to change notification settings - Fork 899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lock file maintenance #3478
Lock file maintenance #3478
Conversation
8844bfa
to
d488b8c
Compare
The failure here is probably because openssl-src got bumped from 111 to 300. |
7c5f2e4
to
8f2580b
Compare
Claim. @djc Thanks for your pointers! This seems to be an OpenSSLv3-specific problem. On a Debian system this should be reachable from However, looking at
|
8f2580b
to
185a836
Compare
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. ⚠ Warning: custom changes will be lost. |
2fcb36f
to
b29bb52
Compare
Looking at #1815, the base image here seems to be https://github.com/rust-lang/rust/blob/e08de860365aa73653dc5fc45b09f194785f3e57/src/ci/docker/host-x86_64/dist-x86_64-linux/Dockerfile. Should we put this info in the docs somewhere? |
b29bb52
to
e007902
Compare
e007902
to
aa972e5
Compare
Leaving a note for my future self (or anyone else it may concern): #1724 (comment) points to rust-lang/rust#59420, which implies that in By referring to this map: rustup/ci/fetch-rust-docker.bash Lines 17 to 20 in cd3a10f
we are actually referring to Dockerfile s located in https://github.com/rust-lang/rust/tree/master/src/ci/docker/host-x86_64.
For example, rustup/ci/fetch-rust-docker.bash Line 20 in cd3a10f
means that for rust-aarch64-unknown-linux-musl :
we should refer to https://github.com/rust-lang/rust/blob/master/src/ci/docker/host-x86_64/dist-arm-linux/Dockerfile. |
c24b4cd
to
d68f56e
Compare
d68f56e
to
44da850
Compare
CI change lgtm |
If I'm not misreading I only see comment changes, so how did the previous issues in CI actually get fixed? |
There's an additional perl package installed
…On Sun, Oct 8, 2023, 3:07 PM Dirkjan Ochtman ***@***.***> wrote:
If I'm not misreading I only see comment changes, so how did the previous
issues in CI actually get fixed?
—
Reply to this email directly, view it on GitHub
<#3478 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAAGBHZUUEHJA64A62PEP3X6L2YRAVCNFSM6AAAAAA4SS4KM6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJSGEZTIMRYGI>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, missed that on my phone. LGTM!
For the future, might be nice to keep comment additions in a separate commit from the fix in the Dockerfile
.
@djc Oh I did exactly that to ensure both commits are green on CI. |
@rami3l sorry, I meant one more commit: one to add comments, and one for the fix to add the Perl dependency. |
This PR contains the following updates:
🔧 This Pull Request updates lock files to use the latest dependency versions.
Configuration
📅 Schedule: Branch creation - "before 4am on monday" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR has been generated by Mend Renovate. View repository job log here.