Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arbitrary self types v2: dev guide updates. #2168

Draft
wants to merge 2,553 commits into
base: master
Choose a base branch
from
Draft

Arbitrary self types v2: dev guide updates. #2168

wants to merge 2,553 commits into from

Conversation

adetaylor
Copy link

No description provided.

tshepang and others added 30 commits March 19, 2024 19:12
@tshepang @fmease
typo
d4c8701
@CBSpeir @tshepang
Fix broken link in chapter '1. How to build and run the compiler'
db46d3e 
The 'read this chapter' link under the 'What is x.py?' section
returned a Document not found (404) error.
@lcnr @BoxyUwU
canonicalization is out of date
87894b0
@lcnr @BoxyUwU
explore significant changes with the new solver
a10a29a
@lcnr @BoxyUwU
is this sensible? idk
66d43a8
@lcnr @oli-obk @BoxyUwU
Update src/solve/significant-changes.md
92066e7 
Co-authored-by: Oli Scherer <[email protected]>
@lcnr @oli-obk @BoxyUwU
Update src/solve/significant-changes.md
0c4c6d7 
Co-authored-by: Oli Scherer <[email protected]>
@lcnr @BoxyUwU
explain rigid aliases
f1698b1
@lcnr @oli-obk
add chapter to summary
8f6a4f6
@fmease @oli-obk
Rename AstConv to HIR ty lowering
ffa246b
@aliemjay @oli-obk
add opaque-types-region-inference-restrictions
45d0afb
@aliemjay @oli-obk
summary: opaque-types-region-inference-restrictions
1ddb90c
@tshepang
Fix some comments
35e77b8 
Signed-off-by: JohnEndson <[email protected]>
@Noratrieb
Delete length check (rust-lang#1952)
f109549 
It's super annoying to be forced to use this bad convention, and
apparently everyone agrees. The only reason no improvements have been
done is because those were blocked on writing a better checker.

I strongly believe that no checker is better than a bad checker, so
let's just delete it in the meantime. I kindly asked anyone who sees
this to complain about overly long sentences in review in the future, I
think we can make this turn out fine.
@Noratrieb
Add quickstart for how to build and run the compiler (rust-lang#1951)
f66b472 
* Add quickstart for how to build and run the compiler

The chapter is quite long, and a lot of the information is, while
valuable, not very important for newcomers. I think it makes sense to
have a condensed version for anyone just wanting to get started with
only the most important information.

* A few improvements to quickstart
@BoxyUwU
Initial rewrite
317a4e2
@BoxyUwU
Change location in guide
f2adb25
@BoxyUwU
reviews
01810f4
@BoxyUwU
Reorganise into subchapters and explain Reveal
e8cd1d9
@BoxyUwU
Fix some broken links
84bbfc3
@TimNN @tshepang
Replace -Zno-parallel-llvm with -Zno-parallel-backend
4375d85 
This was renamed by rust-lang/rust#116791.
@pmundkur
Fix some broken links under bootstrapping. (rust-lang#1958)
5d1fdd3 
* Fix some broken links under bootstrapping.

* Fix more broken links for bootstrapping.
@ehuss
Add needs-threads header command (rust-lang#1943)
0b6f210
@Enselic
Add basic docs for the new aux-bin header (rust-lang#1942)
b735c7e
@notriddle @fmease
Add docs for sharded descriptions
55f79b5
@jieyouxu
Explicitly mention compiletest directives are supported in rmake.rs (r…
b77a34b 
…ust-lang#1949)
@jieyouxu
compiletest: specify which special env var and which particular CI job (
61c1e83 
rust-lang#1960)

* compiletest: specify which special env var and which particular CI job

* compiletest: fix grammar and add link to Dockerfile
@needsure @tshepang
chore: fix some typos in conments
9fbba97 
Signed-off-by: needsure <[email protected]>
@jieyouxu @tshepang
compiletest: clarify that headers must be one header per line
f703523
@tgross35
Add a note about checks with multiple revisions (rust-lang#1963)
07425fe
BoxyUwU and others added 22 commits November 22, 2024 11:17
@BoxyUwU
Remove constants section as it is outdated
787b416
@cjgillot
Remove -Zfuel. (rust-lang#2032)
ca3ae30
@kw217 @tgross35
Fix trivial typo
299a6c8 
"And" should be "An" - one instance.
@jieyouxu
Remove pretty-expanded as it no longer exists (rust-lang#2147)
220aaee
@jieyouxu @ehuss
Update //@ proc-macro aux build directive docs (rust-lang#2149)
3d042d4 
Co-authored-by: Eric Huss <[email protected]>
@jieyouxu
Explain how to deal with exploded git submodules (rust-lang#2152)
5c95a5c
@jieyouxu
Spell out git submodule deinit -f --all (rust-lang#2153)
b21d99b
@jieyouxu
Document needs-target-has-atomic directive (rust-lang#2154)
e312507
@jieyouxu
Remove //@ compare-output-lines-by-subset directive (rust-lang#2151)
797fc7c
@lcnr
closure constraints (rust-lang#2155)
d96eef9
@lcnr
update section even more (rust-lang#2156)
533ca4a
@RalfJung
squashing: recommend --keep-base when squashing without a conflict (r…
17a6c0b 
…ust-lang#2157)
@BoxyUwU
remove polymorphization
1f85706
@tshepang
functionality removed from codebase (rust-lang#2159)
a325c2b
@tshepang
functionality removed from codebase (part 2) (rust-lang#2160)
e7dd865
@connortsui20
specify what a CGU is (rust-lang#2163)
7f7ba48
@ehuss
Add suggestion for --keep-stage 0 (rust-lang#2164)
36ea4b4
@rmehri01 @tshepang
Fix some typos
22ef886
@tshepang
typo, pause
1bf21e3
@cbloodsworth @tshepang
Fix trivial typo of "query-fied"
6604b46 
"Query-field" should be "Query-fied" - three instances.
@marcoieni
document the public ci dashboard (rust-lang#2167)
1eac2a9
@adetaylor
Arbitrary self types v2: dev guide updates.
f21f094
@adetaylor adetaylor mentioned this pull request Dec 19, 2024
Open
15 tasks
@jieyouxu jieyouxu added S-blocked Status: this PR is blocked waiting for something F-arbitrary_self_types Feature: arbitrary_self_types T-compiler Relevant to compiler team T-types Relevant to types team labels Dec 20, 2024
@Kobzol
Copy link
Contributor

Kobzol commented Jan 5, 2025

Sorry, due to me messing up a git operation, we sadly had to force-push the whole commit history of rustc-dev-guide :( If you'd like to update this pull request, you will have to rebase it in a special way onto the new commit history (the new master):

git fetch origin --all
git checkout <pr-branch>
git rebase --onto origin/master origin/master-old
git push --force-with-lease

More context can be found here.

@adetaylor adetaylor mentioned this pull request Jan 24, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
F-arbitrary_self_types Feature: arbitrary_self_types S-blocked Status: this PR is blocked waiting for something T-compiler Relevant to compiler team T-types Relevant to types team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.