Document behavior of multiple stability attributes on items #2128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since this method has been renamed in rustc. Also remove a link to documentation in error-guaranteed.md because it was unused
Co-authored-by: Tshepang Mbambo <[email protected]>
These were removed in 2021. rust-lang/rust#85993
* add implied bounds doc * lazy type aliases also have explicit implied bounds
* add opaque types doc * summary
* make shell.nix better * Mention using RUST_BOOTSTRAP_CONFIG * Move things to `buildInputs` and add `glibc.out glibc.static` This fixes the nofile-limit.rs UI test. * short lines for the short line fans * Fix pkgs
* Add some more details on feature gating * Apply suggestions from code review --------- Co-authored-by: Ross Smyth <[email protected]> Co-authored-by: Nilstrieb <[email protected]>
* Use different type in an example Sentences such as «without the argument u32» were ambiguous, as there were two distincts u32. Having a single one, the one in the monomorphization of the type, remove the ambiguity. * Update src/ty.md --------- Co-authored-by: Nilstrieb <[email protected]>
rust-lang#1914) This patch also adds docs for `//@ llvm-cov-flags:`, and notes that coverage tests support revisions (though none of the current tests actually do so).
* Update overview.md Various link addition and minor edits for clarity. * generic improvements * fix line lengths for ci/cd --------- Co-authored-by: Tbkhi <[email protected]> Co-authored-by: Oliver Dechant <[email protected]>
* adding links * Update src/rustc-driver-interacting-with-the-ast.md Co-authored-by: Tshepang Mbambo <[email protected]> * redo links and formatting * Update rustc-driver-interacting-with-the-ast.md --------- Co-authored-by: Tshepang Mbambo <[email protected]>
Minor additions and resorting.
Co-authored-by: Jieyou Xu <[email protected]>
The original issue has been fixed, the workaround is no longer necessary.
we encountered this in rust-lang/rust#131038 kinda felt like an unspoken rule so here's a more concrete clarification.
jieyouxu
added
T-libs
jieyouxu
added
S-blocked
|
Sorry, due to me messing up a git operation, we sadly had to force-push the whole commit history of rustc-dev-guide :( If you'd like to update this pull request, you will have to rebase it in a special way onto the new commit history (the new More context can be found here. |
|
On a related note now that the dev guide is a subtree you might consider making these changes as part of your rust-lang/rust PR by editing the |
|
No worries! Having these changes as part of the rust-lang/rust PR sounds nicer anyway. That PR needs a pretty massive rebase I think, but once I get to that I'll be sure to update the dev guide there. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This documents the changes made in rust-lang/rust#131824, and so should be blocked on that.
The checklist for stabilizing a library feature (and its mirror in the standard library developers guide) technically still works; its suggestion to change
#[unstable]attributes to#[stable]should always have the correct behavior. Let me know if it should be recommended to avoid mixing#[stable]/#[unstable]or having multiple#[stable]s in hand-written code though; I can make a note about removing rather than changing#[unstable]attributes in that case. cc @rust-lang/libs @rust-lang/libs-api