-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish compiletest as a rustc-tools component #99968
Publish compiletest as a rustc-tools component #99968
Conversation
@bors try |
⌛ Trying commit 6d7529751460ac93bcdf0b62122bc299e0d24060 with merge 9834b0310d8ad7a4fbca6ee673ffea9161757275... |
I think we should hold off on merging this until we confirm with the clippy team this is the approach they want to take. No objection to doing this, just don't want it to be wasted work. |
Sure, that's fine with me -- in particular clarity on library vs. binary I think would be good. Mostly wanted to open this so we can get a try build + a "fake" nightly published from it so it's easier to experiment with (for example) a clippy PR migrating to this. |
☀️ Try build successful - checks-actions |
6d75297
to
9223b0c
Compare
@bors try |
⌛ Trying commit 9223b0c with merge 1a32bcf2c3a5c2b33a30b93b1228eb9eb7ca6a9f... |
cc @rust-lang/clippy |
☀️ Try build successful - checks-actions |
The goal of this PR is to just get the publishing working in a way that'll hopefully let clippy consume the resulting binary without too much trouble. If there's a desire to use compiletest as a library rather than a binary, I see no reason why we couldn't publish an rlib/.so/whatever, just like we do for std or the rustc libraries, that'll just take more plumbing. My hope is that the binary is a sufficient interface for now, since that works for rustc itself (bootstrap calls the binary), but if not, we can modify this PR to publish an rlib into the sysroot too, when the compiletest component is installed.
It looks like as-is clippy does use the library compiletest-rs as a library for its testing, I would need to do more digging to tell if that's an intrinsic dependency or not.
cc @Manishearth @oli-obk rust-lang/compiler-team#536
r? @jyn514