use check_region_obligations_and_report_errors to avoid ICEs

[compiler-errors]

If we don't call process_registered_region_obligations before resolve_regions_and_report_errors then we'll ICE if we have any region obligations, and check_region_obligations_and_report_errors just does both of these for us in a nice convenient function.

Fixes #53475

r? types

[oli-obk]

Are there any callers to resolve_regions_and_report_errors left? If so, maybe document this issue on the function itself to prevent additional mis-uses

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

[bors]

⌛ Trying commit 1694ea1 with merge 2ef4c8b9ce5c90a2ff5e91285b32cee773416e3b...

[bors]

☀️ Try build successful - checks-actions
Build commit: 2ef4c8b9ce5c90a2ff5e91285b32cee773416e3b (2ef4c8b9ce5c90a2ff5e91285b32cee773416e3b)

[rust-timer]

Queued 2ef4c8b9ce5c90a2ff5e91285b32cee773416e3b with parent ff693dc, future comparison URL.

[rust-timer]

Finished benchmarking commit (2ef4c8b9ce5c90a2ff5e91285b32cee773416e3b): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

• Primary benchmarks: 😿 relevant regressions found
• Secondary benchmarks: 🎉 relevant improvement found

	mean1	max	count2
Regressions 😿 (primary)	2.1%	3.6%	2
Regressions 😿 (secondary)	N/A	N/A	0
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	-2.8%	-2.8%	1
All 😿🎉 (primary)	2.1%	3.6%	2

Cycles

This benchmark run did not return any relevant results for this metric.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Footnotes

1. the arithmetic mean of the percent change ↩

2. number of relevant changes ↩

[oli-obk]

Are there any callers to resolve_regions_and_report_errors left? If so, maybe document this issue on the function itself to prevent additional mis-uses

r=me with this resolved

@rustbot author

[oli-obk]

@bors r+

[bors]

📌 Commit 16f4980 has been approved by oli-obk

It is now in the queue for this repository.

[bors]

⌛ Testing commit 16f4980 with merge 110777b...

[bors]

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 110777b to master...

[rust-timer]

Finished benchmarking commit (110777b): comparison url.

Instruction count

• Primary benchmarks: no relevant changes found
• Secondary benchmarks: 😿 relevant regression found

	mean1	max	count2
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	1.1%	1.1%	1
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	N/A	N/A	0
All 😿🎉 (primary)	N/A	N/A	0

Max RSS (memory usage)

Results

• Primary benchmarks: mixed results
• Secondary benchmarks: 🎉 relevant improvements found

	mean1	max	count2
Regressions 😿 (primary)	2.0%	3.1%	2
Regressions 😿 (secondary)	N/A	N/A	0
Improvements 🎉 (primary)	-2.3%	-2.3%	1
Improvements 🎉 (secondary)	-3.1%	-3.8%	2
All 😿🎉 (primary)	0.6%	3.1%	3

Cycles

Results

• Primary benchmarks: 😿 relevant regressions found
• Secondary benchmarks: 🎉 relevant improvements found

	mean1	max	count2
Regressions 😿 (primary)	2.5%	2.7%	2
Regressions 😿 (secondary)	N/A	N/A	0
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	-4.7%	-5.5%	5
All 😿🎉 (primary)	2.5%	2.7%	2

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

1. the arithmetic mean of the percent change ↩ ↩² ↩³

2. number of relevant changes ↩ ↩² ↩³