Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove erroneous E0133 code from an error message. #99739

Merged
merged 1 commit into from
Jul 26, 2022

Conversation

nnethercote
Copy link
Contributor

This error message is about derive and packed, but E0133 is for
"Unsafe code was used outside of an unsafe function or block".

r? @estebank

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jul 26, 2022
@rustbot
Copy link
Collaborator

rustbot commented Jul 26, 2022

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 26, 2022
@nnethercote
Copy link
Contributor Author

@bors rollup=always

@rust-log-analyzer

This comment has been minimized.

This error message is about `derive` and `packed`, but E0133 is for
"Unsafe code was used outside of an unsafe function or block".
@Dylan-DPC
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Jul 26, 2022

📌 Commit 6a4b157 has been approved by Dylan-DPC

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 26, 2022
@Dylan-DPC

This comment was marked as duplicate.

@bors
Copy link
Contributor

bors commented Jul 26, 2022

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Contributor

bors commented Jul 26, 2022

📌 Commit 6a4b157 has been approved by Dylan-DPC

It is now in the queue for this repository.

Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Jul 26, 2022
Remove erroneous E0133 code from an error message.

This error message is about `derive` and `packed`, but E0133 is for
"Unsafe code was used outside of an unsafe function or block".

r? `@estebank`
This was referenced Jul 26, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 26, 2022
Rollup of 5 pull requests

Successful merges:

 - rust-lang#99618 (handle consts with param/infer in `const_eval_resolve` better)
 - rust-lang#99666 (Restore `Opaque` behavior to coherence check)
 - rust-lang#99692 (interpret, ptr_offset_from: refactor and test too-far-apart check)
 - rust-lang#99739 (Remove erroneous E0133 code from an error message.)
 - rust-lang#99748 (Use full type name instead of just saying `impl Trait` in "captures lifetime" error)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 962da8b into rust-lang:master Jul 26, 2022
@rustbot rustbot added this to the 1.64.0 milestone Jul 26, 2022
@nnethercote nnethercote deleted the rm-E0133 branch July 26, 2022 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants