Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make uninit checks stricter but avoid issues for old hyper #99389

Closed
wants to merge 8 commits into from
Closed

Make uninit checks stricter but avoid issues for old hyper #99389

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
85545dd
Make uninit checks stricter but avoid issues for old hyper
5225225 Jul 17, 2022
c84936e
Fix docs
5225225 Jul 18, 2022
6770c21
Still do the type walking for zero init checks
5225225 Jul 18, 2022
a2f44ac
We ignore all references to size 0 align 1 data.
5225225 Jul 18, 2022
a007e7b
Reword explanation for ignoring ZST 1-aligned references
5225225 Jul 18, 2022
5ee555c
Only panic for refs to slices and str, not dyn trait
5225225 Jul 20, 2022
eb1b384
Adjust justification comment
5225225 Jul 20, 2022
a6ab54b
Change comment to mention vtable
5225225 Jul 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
We ignore all references to size 0 align 1 data.
  • Loading branch information
@5225225
5225225 committed Aug 1, 2022
commit a2f44ac649af95a294520a5ec49080b94f495e91
5 changes: 3 additions & 2 deletions compiler/rustc_middle/src/ty/layout.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3498,7 +3498,7 @@ fn make_thin_self_ptr<'tcx>(
///
/// This code is intentionally conservative, and will not detect
/// * making uninitialized types who have a full valid range (ints, floats, raw pointers)
/// * uninit `&[T]` where T has align 1 (only inside arrays). This includes `&str`
/// * uninit `&T` where T has align 1 size 0 (only inside arrays).
/// * zero init enums where a discriminant with tag 0 exists, but is invalid to be zeroed
/// * zero init type that does not allow zero init (only inside arrays)
///
Expand Down Expand Up @@ -3547,7 +3547,8 @@ where
// See: https://github.com/rust-lang/rust/pull/99389
if inside_array {
match init_kind {
// FIXME(#66151) We need to ignore uninit slice references with an alignment of 1
// FIXME(#66151) We need to ignore uninit references with an alignment of 1 and
// size 0
// (as in, &[u8] and &str)
// Since if we do not, old versions of `hyper` with no semver compatible fix
// (0.11, 0.12, 0.13) break.
Expand Down