Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[beta] rollup #99300

Merged
merged 8 commits into from
Jul 16, 2022
Merged

[beta] rollup #99300

merged 8 commits into from
Jul 16, 2022

Conversation

Mark-Simulacrum
Copy link
Member

r? @Mark-Simulacrum

@rustbot rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 15, 2022
@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@rustbot

This comment was marked as resolved.

Sign in to view
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 15, 2022
nikomatsakis and others added 3 commits July 15, 2022 18:50
@nikomatsakis @Mark-Simulacrum
promote placeholder bounds to 'static obligations
44b476e 
In NLL, when we are promoting a bound out from a closure,
if we have a requirement that `T: 'a` where `'a` is in a
higher universe, we were previously ignoring that, which is
totally wrong. We should be promoting those constraints to `'static`,
since universes are not expressible across closure boundaries.
@cjgillot @Mark-Simulacrum
Add known bug test.
7c2b316
@cjgillot @Mark-Simulacrum
Handle fresh lifetimes on bare trait objects.
f0227e8
@Mark-Simulacrum
Copy link
Member Author

@bors r+ rollup=never

@bors
Copy link
Contributor

bors commented Jul 15, 2022

📌 Commit f0227e8 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 15, 2022
@Mark-Simulacrum
Copy link
Member Author

@bors p=5

Want to try to get this in in time for crater.

@bors
Copy link
Contributor

bors commented Jul 16, 2022

⌛ Testing commit f0227e8 with merge efd3583...

@bors
Copy link
Contributor

bors commented Jul 16, 2022

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing efd3583 to beta...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 16, 2022
@bors bors merged commit efd3583 into rust-lang:beta Jul 16, 2022
@rustbot rustbot added this to the 1.63.0 milestone Jul 16, 2022
@Mark-Simulacrum Mark-Simulacrum deleted the beta-next branch July 16, 2022 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.63.0
Development

Successfully merging this pull request may close these issues.
8 participants
@Mark-Simulacrum @rust-highfive @rustbot @bors @compiler-errors @ChrisDenton @nikomatsakis @cjgillot