Set crt_static_respected and crt_static_default to true for the Emscripten target #99243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
rust-highfive
added
the
S-waiting-on-review
|
I'll mark this as blocked on #98358 because if |
petrochenkov
added
S-blocked
|
Though tests fail on #98358 because this change isn't included so maybe I should just join this into that PR. With this change, that PR doesn't modify the default behavior since the default will end up being one of the do-nothing branches of setOutputKind |
workingjubilee
added
the
O-emscripten
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a followup to #98358, we should switch the default output kind to be static and allow the user to toggle it.
If I understand correctly, we are using
crt-staticto mean something different than it was originally intended to mean. It sounds like it normally controls whether libc is linked statically or dynamically. In Emscripten, it is impossible to dynamically link libc. However, standard Emscripten builds have dynamic linking disabled entirely. We are using+crt-staticto mean "disable dynamic linking" and-crt-staticto mean "enable dynamic linking".@sbc100
r? @petrochenkov