-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adapt native-link-modifier-bundle test to use llvm-nm #98573
Conversation
(rust-highfive has picked a reviewer for you, use r? to override) |
Can you please squash the commits? |
done |
@bors r+ rollup=never |
📌 Commit 26b48fc8c5d8aa8c9d2fa1936f5c79fb26ed10c7 has been approved by |
@bors r- |
@bors r+ |
📌 Commit 26b48fc8c5d8aa8c9d2fa1936f5c79fb26ed10c7 has been approved by |
@bors r+ |
📌 Commit c1ed82f5f28d13072894157bed630eece6fc74d9 has been approved by |
Well, no idea what went wrong, but closing and reopening helped :) |
⌛ Testing commit c1ed82f5f28d13072894157bed630eece6fc74d9 with merge 88dd358e884c13ea8b9d82b0108af381ab05d291... |
💔 Test failed - checks-actions |
This comment has been minimized.
This comment has been minimized.
Path to |
I'll try escaping this differently. Not sure how to re-try the |
Seems to use the same spelling as other LLVM tools in tests now, so let's hope that works... @bors r+ |
📌 Commit aa4c8f6 has been approved by |
☀️ Test successful - checks-actions |
Finished benchmarking commit (17581a7): comparison url. Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results
CyclesThis benchmark run did not return any relevant results for this metric. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression Footnotes |
No functional changes intended.
This updates the test case to use
llvm-nm
as an alternative to #98424.This fixes a test failure over at the experimental build of rustc with HEAD LLVM:
https://buildkite.com/llvm-project/rust-llvm-integrate-prototype/builds/11144#01814d0f-a46a-4c19-91cf-41e720edb6f9/684-691.
The issue is that this test uses the system nm, which may not be recent
enough to understand the bitcode produced by rustc when compiled against HEAD LLVM.
Similar to what we did for another test in #94023.