-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Seek instance for std::io::Take #97807
Conversation
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @joshtriplett (or someone else) soon. Please see the contribution instructions for more information. |
r? rust-lang/libs-api |
☔ The latest upstream changes (presumably #99707) made this pull request unmergeable. Please resolve the merge conflicts. |
Hello @wangbj! I noticed this PR has a merge conflict, has there been any updates? |
Closing the pr as inactive. Feel free to create a new pr or reöpen this if you plan on continuing with it. |
Library tracking issue #97227.
Previous PR: #97230
I made a mistake (I'm a git noob) by using
merge
commits which is not allowed in PR. hence creating a new PR will close the old one.Change summary:
std::io::Take
.impl Seek
forstd::io::Take
..take(N)
can return less data thanN
, we also call an initialseek
to determine how many bytes are available. This is done in theseek
function and it is called only once.