Remove fmt! usage from the compiler #9599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1357,7 +1357,7 @@ mod tests { | |||
| let mut b = Bitv::new(14, true); | |||
| b.clear(); | |||
| do b.ones |i| { | |||
| fail!("found 1 at %?", i) | |||
| fail2!("found 1 at %?", i) | |||
There was a problem hiding this comment.
this one and the next is still using %?, is that correct?
|
Needs a rebase (surprise surprise!), and I think it may be worth making |
|
Aha, now |
|
It doesn't pass github's automatic-merge-detector though. |
We're not outright removing fmt! just yet, but this prevents it from leaking into the compiler further (it's still turned on by default for all other code).
bors
added a commit
that referenced
this pull request
Oct 1, 2013
This also prevents future fmt! usage from leaking into the compiler, but it's still turned on by default for everyone else.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Oct 6, 2022
Add a temporary workaround for multiline formart arg inlining per suggestion in rust-lang#102729 (comment) workaround for an internal crash when handling multi-line format argument inlining. changelog: none (no point for changelog because it is still a new lint being introduced)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also prevents future fmt! usage from leaking into the compiler, but it's still turned on by default for everyone else.