Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inline tuple_fields #94928

Merged
merged 1 commit into from
Mar 15, 2022
Merged

inline tuple_fields #94928

merged 1 commit into from
Mar 15, 2022

Conversation

lcnr
Copy link
Contributor

@lcnr lcnr commented Mar 14, 2022

more #93505 fun, after this i have no idea what might be causing the perf impact.

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Mar 14, 2022
@rust-highfive
Copy link
Collaborator

r? @davidtwco

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 14, 2022
@lcnr
Copy link
Contributor Author

lcnr commented Mar 14, 2022

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 14, 2022
@bors
Copy link
Contributor

bors commented Mar 14, 2022

⌛ Trying commit 423600d with merge 21b401a310360c8e5cfecbcd5cb790662722386d...

@bors
Copy link
Contributor

bors commented Mar 14, 2022

☀️ Try build successful - checks-actions
Build commit: 21b401a310360c8e5cfecbcd5cb790662722386d (21b401a310360c8e5cfecbcd5cb790662722386d)

@rust-timer
Copy link
Collaborator

Queued 21b401a310360c8e5cfecbcd5cb790662722386d with parent b751124, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (21b401a310360c8e5cfecbcd5cb790662722386d): comparison url.

Summary: This benchmark run did not return any relevant results. 4 results were found to be statistically significant but too small to be relevant.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 14, 2022
@lcnr
Copy link
Contributor Author

lcnr commented Mar 14, 2022

seems like a slight improvement

@michaelwoerister
Copy link
Member

Seems reasonable in any case.
@bors r+

@bors
Copy link
Contributor

bors commented Mar 15, 2022

📌 Commit 423600d has been approved by michaelwoerister

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 15, 2022
@bors
Copy link
Contributor

bors commented Mar 15, 2022

⌛ Testing commit 423600d with merge be52b4a...

@bors
Copy link
Contributor

bors commented Mar 15, 2022

☀️ Test successful - checks-actions
Approved by: michaelwoerister
Pushing be52b4a to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 15, 2022
@bors bors merged commit be52b4a into rust-lang:master Mar 15, 2022
@rustbot rustbot added this to the 1.61.0 milestone Mar 15, 2022
@lcnr lcnr deleted the inline-as_substs branch March 15, 2022 16:02
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (be52b4a): comparison url.

Summary: This benchmark run did not return any relevant results.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants