Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[beta] Backport CI fixes for python certificates #90953

Closed
wants to merge 2 commits into from

Conversation

flip1995
Copy link
Member

@flip1995 flip1995 commented Nov 16, 2021

This backports #90457 to the beta branch, which should fix the CI, so that both beta backport PRs #90938 and #90561 can be merged.

r? @Mark-Simulacrum

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 16, 2021
@flip1995
Copy link
Member Author

@bors try

@bors
Copy link
Contributor

bors commented Nov 16, 2021

⌛ Trying commit 91fadf5 with merge b8ead6f263004ec9d91dc6b77adb46c520fb0d87...

@bors
Copy link
Contributor

bors commented Nov 16, 2021

☀️ Try build successful - checks-actions
Build commit: b8ead6f263004ec9d91dc6b77adb46c520fb0d87 (b8ead6f263004ec9d91dc6b77adb46c520fb0d87)

@cuviper cuviper mentioned this pull request Nov 16, 2021
@Mark-Simulacrum
Copy link
Member

@cuviper do you want to roll this into the rollup you have going? r=me on the changes themselves.

@cuviper
Copy link
Member

cuviper commented Nov 16, 2021

Sure, I'll add it.

@apiraino apiraino added the T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. label Nov 18, 2021
@cuviper
Copy link
Member

cuviper commented Nov 19, 2021

We included this in #90938, thanks!

@cuviper cuviper closed this Nov 19, 2021
@flip1995 flip1995 deleted the ci-backport branch November 21, 2021 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants