Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unneeded FIXMEs comments in search index generation #90757

Merged
merged 1 commit into from
Nov 14, 2021
Merged

Remove unneeded FIXMEs comments in search index generation #90757

merged 1 commit into from
Nov 14, 2021

Conversation

GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Nov 10, 2021 •
edited
Loading

Original comment:

Instead of recreating a new vec for each arguments, we re-use the same. The impact on performance should be minor but worth a try.

After testing it, we reached the conclusion that the code readability drop wasn't worth the almost unnoticeable performance improvement.

r? @camelid

@GuillaumeGomez GuillaumeGomez added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Nov 10, 2021
@GuillaumeGomez
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Nov 10, 2021
@bors
Copy link
Contributor

bors commented Nov 10, 2021

⌛ Trying commit 02dd43f9b3f2e025e4e9a32c8e4578b4be6b0ff7 with merge 043642e66c714c8fbbc3729258ed12347e73ee0a...

@GuillaumeGomez GuillaumeGomez force-pushed the search-index-performance branch from 02dd43f to 72ce662 Compare November 10, 2021 10:48
@GuillaumeGomez
Copy link
Member Author

Let's see if I can restart the perf check...

@bors try-

@GuillaumeGomez
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@bors
Copy link
Contributor

bors commented Nov 10, 2021

⌛ Trying commit 72ce6629a5d5c2584f318bafaf08719a03c9ffae with merge 53b25d576438035cc26fbc95518b151e19ea67a3...

@bors
Copy link
Contributor

bors commented Nov 10, 2021

☀️ Try build successful - checks-actions
Build commit: 53b25d576438035cc26fbc95518b151e19ea67a3 (53b25d576438035cc26fbc95518b151e19ea67a3)

@rust-timer
Copy link
Collaborator

Queued 53b25d576438035cc26fbc95518b151e19ea67a3 with parent 493ea77, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (53b25d576438035cc26fbc95518b151e19ea67a3): comparison url.

Summary: This change led to large relevant regressions 😿 in compiler performance.

  • Large regression in instruction counts (up to 1.1% on incr-unchanged builds of wg-grammar)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

@rustbot rustbot added perf-regression Performance regression. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Nov 10, 2021
@GuillaumeGomez
Copy link
Member Author

So interestingly enough, there is no perf change, however the RSS usage reduced up to 6%. I definitely didn't expect that...

@GuillaumeGomez GuillaumeGomez marked this pull request as ready for review November 10, 2021 14:51
@GuillaumeGomez GuillaumeGomez force-pushed the search-index-performance branch from 72ce662 to de24920 Compare November 10, 2021 15:10
@GuillaumeGomez
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Nov 10, 2021
@bors
Copy link
Contributor

bors commented Nov 10, 2021

⌛ Trying commit de2492090bfcc9b7fa663f29f2c186d7ef2cc9aa with merge 1fd792ae63cdf706c0d3029ea66fae8ea92189c3...

@bors
Copy link
Contributor

bors commented Nov 10, 2021

☀️ Try build successful - checks-actions
Build commit: 1fd792ae63cdf706c0d3029ea66fae8ea92189c3 (1fd792ae63cdf706c0d3029ea66fae8ea92189c3)

@rust-timer
Copy link
Collaborator

Queued 1fd792ae63cdf706c0d3029ea66fae8ea92189c3 with parent 800a156, future comparison URL.

@GuillaumeGomez
Remove unneeded FIXME: after testing the suggested changes, we reache…
6b3695d 
…d the conclusion that the code readibility wasn't worth the almost unnoticeable perf improvement
@GuillaumeGomez GuillaumeGomez force-pushed the search-index-performance branch from d5c45b0 to 6b3695d Compare November 12, 2021 14:25
@GuillaumeGomez GuillaumeGomez changed the title Improve performance to generate search index Remove unneeded FIXMEs comments in search index generation Nov 12, 2021
@GuillaumeGomez
Copy link
Member Author

Done! I updated the first comment as well as the commit message.

@camelid
Copy link
Member

camelid commented Nov 12, 2021

Thanks :)

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Nov 12, 2021

📌 Commit 6b3695d has been approved by camelid

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 12, 2021
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 13, 2021
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 13, 2021
@matthiaskrgr
Rollup merge of rust-lang#90757 - GuillaumeGomez:search-index-perform…
7196402 
…ance, r=camelid

Remove unneeded FIXMEs comments in search index generation

Original comment:

> Instead of recreating a new `vec` for each arguments, we re-use the same. The impact on performance should be minor but worth a try.

After testing it, we reached the conclusion that the code readability drop wasn't worth the almost unnoticeable performance improvement.

r? `@camelid`
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 13, 2021
@matthiaskrgr
Rollup merge of rust-lang#90757 - GuillaumeGomez:search-index-perform…
b6ef12d 
…ance, r=camelid

Remove unneeded FIXMEs comments in search index generation

Original comment:

> Instead of recreating a new `vec` for each arguments, we re-use the same. The impact on performance should be minor but worth a try.

After testing it, we reached the conclusion that the code readability drop wasn't worth the almost unnoticeable performance improvement.

r? ``@camelid``
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 13, 2021
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 13, 2021
@matthiaskrgr
Rollup merge of rust-lang#90757 - GuillaumeGomez:search-index-perform…
3f815e7 
…ance, r=camelid

Remove unneeded FIXMEs comments in search index generation

Original comment:

> Instead of recreating a new `vec` for each arguments, we re-use the same. The impact on performance should be minor but worth a try.

After testing it, we reached the conclusion that the code readability drop wasn't worth the almost unnoticeable performance improvement.

r? ```@camelid```
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 13, 2021
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 13, 2021
@matthiaskrgr
Rollup merge of rust-lang#90757 - GuillaumeGomez:search-index-perform…
3cd3b7a 
…ance, r=camelid

Remove unneeded FIXMEs comments in search index generation

Original comment:

> Instead of recreating a new `vec` for each arguments, we re-use the same. The impact on performance should be minor but worth a try.

After testing it, we reached the conclusion that the code readability drop wasn't worth the almost unnoticeable performance improvement.

r? ````@camelid````
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 13, 2021
Closed
@bors
Copy link
Contributor

bors commented Nov 14, 2021

⌛ Testing commit 6b3695d with merge 6d38743...

@bors
Copy link
Contributor

bors commented Nov 14, 2021

☀️ Test successful - checks-actions
Approved by: camelid
Pushing 6d38743 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 14, 2021
@bors bors merged commit 6d38743 into rust-lang:master Nov 14, 2021
@rustbot rustbot added this to the 1.58.0 milestone Nov 14, 2021
@GuillaumeGomez GuillaumeGomez deleted the search-index-performance branch November 14, 2021 13:53
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (6d38743): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the8472 the8472 the8472 left review comments

@CryZe CryZe CryZe left review comments

@jyn514 jyn514 jyn514 requested changes

@camelid camelid camelid left review comments

Assignees

@camelid camelid

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.58.0
Development

Successfully merging this pull request may close these issues.
8 participants
@GuillaumeGomez @rust-timer @bors @camelid @the8472 @CryZe @jyn514 @rustbot