Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't mark for loop iter expression as desugared #89895

Merged
merged 3 commits into from
Oct 22, 2021
Merged

Don't mark for loop iter expression as desugared #89895

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bd1a1e4
Don't mark for loop head span with desugaring
camsteffen Oct 14, 2021
a697aa6
Use more lowered spans in for loop
camsteffen Oct 15, 2021
ffdd5a0
Fix clippy with for loop span change
camsteffen Oct 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix clippy with for loop span change
  • Loading branch information
@camsteffen
camsteffen committed Oct 15, 2021
commit ffdd5a04a4060c19d0dee62a63bcfd2ee1902079
8 changes: 1 addition & 7 deletions src/tools/clippy/clippy_lints/src/vec.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,13 +63,7 @@ impl<'tcx> LateLintPass<'tcx> for UselessVec {
if is_copy(cx, vec_type(cx.typeck_results().expr_ty_adjusted(arg)));
then {
// report the error around the `vec!` not inside `<std macros>:`
let span = arg.span
.ctxt()
.outer_expn_data()
.call_site
.ctxt()
.outer_expn_data()
.call_site;
let span = arg.span.ctxt().outer_expn_data().call_site;
self.check_vec_macro(cx, &vec_args, Mutability::Not, span);
}
}
Expand Down