-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC2229 Add missing edge case #87996
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
// run-pass | ||
// edition:2021 | ||
|
||
const LIBUSB_HOTPLUG_EVENT_DEVICE_ARRIVED: i32 = 0x01; | ||
const LIBUSB_HOTPLUG_EVENT_DEVICE_LEFT: i32 = 0x02; | ||
|
||
pub fn hotplug_callback(event: i32) { | ||
let _ = || { | ||
match event { | ||
LIBUSB_HOTPLUG_EVENT_DEVICE_ARRIVED => (), | ||
LIBUSB_HOTPLUG_EVENT_DEVICE_LEFT => (), | ||
_ => (), | ||
}; | ||
}; | ||
} | ||
|
||
fn main() { | ||
hotplug_callback(1); | ||
} |
44 changes: 44 additions & 0 deletions
44
src/test/ui/closures/2229_closure_analysis/match-edge-cases.rs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
// run-pass | ||
// edition:2021 | ||
|
||
const PATTERN_REF: &str = "Hello World"; | ||
const NUMBER: i32 = 30; | ||
const NUMBER_POINTER: *const i32 = &NUMBER; | ||
|
||
pub fn edge_case_ref(event: &str) { | ||
let _ = || { | ||
match event { | ||
PATTERN_REF => (), | ||
_ => (), | ||
}; | ||
}; | ||
} | ||
|
||
pub fn edge_case_str(event: String) { | ||
let _ = || { | ||
match event.as_str() { | ||
"hello" => (), | ||
_ => (), | ||
}; | ||
}; | ||
} | ||
|
||
pub fn edge_case_raw_ptr(event: *const i32) { | ||
let _ = || { | ||
match event { | ||
NUMBER_POINTER => (), | ||
_ => (), | ||
}; | ||
}; | ||
} | ||
|
||
pub fn edge_case_char(event: char) { | ||
let _ = || { | ||
match event { | ||
'a' => (), | ||
_ => (), | ||
}; | ||
}; | ||
} | ||
|
||
fn main() {} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am wondering what cases might be missing here -- one silly example might be matching on a constant of type
()
or something like that, which is kind of a no-op.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not too sure either. I am going to import all the match test cases that are here https://github.com/rust-lang/rust/tree/master/src/test/ui/match and then convert them into closure test cases and see if I found anything new