Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crater: closure size profile build #87066

Closed
wants to merge 2 commits into from
Closed

Crater: closure size profile build #87066

wants to merge 2 commits into from

Conversation

arora-aman
Copy link
Member

PR to do a test crater run on just cargo

  • mode=build-only
  • list:cargo
  • rustflags={-Zprofile-closures}
  • p=1 (as suggest here high priority).

@rust-highfive
Copy link
Collaborator

r? @davidtwco

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 11, 2021
@arora-aman
Copy link
Member Author

r? @Mark-Simulacrum

@Mark-Simulacrum
Copy link
Member

@bors try

@bors
Copy link
Contributor

bors commented Jul 11, 2021

⌛ Trying commit de286526f3690610f97da2299ca081aa31e4258f with merge 8a4c071f46be56484e9723bd8f1e5eea08177963...

@bors
Copy link
Contributor

bors commented Jul 11, 2021

☀️ Try build successful - checks-actions
Build commit: 8a4c071f46be56484e9723bd8f1e5eea08177963 (8a4c071f46be56484e9723bd8f1e5eea08177963)

@arora-aman
Copy link
Member Author

Can someone start a crater run with paramters:

  • mode=build-only
  • list:cargo
  • rustflags={-Zprofile-closures}
  • p=1 (as suggest here high priority).

@Mark-Simulacrum
Copy link
Member

@craterbot run mode=build-only crates=list:cargo start=master#e9a387d6cf5961a7f2dcb671da3147bd413355c4 end=try#8a4c071f46be56484e9723bd8f1e5eea08177963+rustflags={-Zprofile-closures} p=1

@craterbot
Copy link
Collaborator

👌 Experiment pr-87066 created and queued.
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 11, 2021
@craterbot
Copy link
Collaborator

🚧 Experiment pr-87066 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment pr-87066 is completed!
📊 0 regressed and 0 fixed (1 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Jul 12, 2021
@Mark-Simulacrum
Copy link
Member

We passed {-Zprofile-closures} as the rustflag argument which is clearly bogus...

@craterbot run mode=build-only crates=list:cargo start=master#e9a387d6cf5961a7f2dcb671da3147bd413355c4 end=try#8a4c071f46be56484e9723bd8f1e5eea08177963+rustflags=-Zprofile-closures p=1

@craterbot
Copy link
Collaborator

👌 Experiment pr-87066-1 created and queued.
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 13, 2021
@craterbot
Copy link
Collaborator

🚧 Experiment pr-87066-1 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment pr-87066-1 is completed!
📊 0 regressed and 0 fixed (1 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Jul 16, 2021
@Mark-Simulacrum
Copy link
Member

@craterbot run mode=build-only crates=list:cargo,serde,libc start=master#e9a387d6cf5961a7f2dcb671da3147bd413355c4 end=try#b37eec28c619960bccdd1d5c1c502ce4dcf83564+rustflags=-Zprofile-closures p=1

@craterbot
Copy link
Collaborator

👌 Experiment pr-87066-2 created and queued.
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 21, 2021
@craterbot
Copy link
Collaborator

🚧 Experiment pr-87066-2 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment pr-87066-2 is completed!
📊 0 regressed and 0 fixed (3 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Jul 25, 2021
@Mark-Simulacrum
Copy link
Member

So it looks like it worked:

Happy to queue a check run across the full set of crates or take a different course of action, please let me know.

@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 1, 2021
@Mark-Simulacrum
Copy link
Member

@bors try

@bors
Copy link
Contributor

bors commented Aug 17, 2021

⌛ Trying commit e6793be with merge d5c88c22807925c189328ef9d923c5d2b11a95b8...

@bors
Copy link
Contributor

bors commented Aug 17, 2021

☀️ Try build successful - checks-actions
Build commit: d5c88c22807925c189328ef9d923c5d2b11a95b8 (d5c88c22807925c189328ef9d923c5d2b11a95b8)

@Mark-Simulacrum
Copy link
Member

@craterbot run mode=build-only crates=top-10000 start=master#d5c88c22807925c189328ef9d923c5d2b11a95b8 end=try#d5c88c22807925c189328ef9d923c5d2b11a95b8+rustflags=-Zprofile-closures

Starting another run to collect some data; we'll likely want to abort and re-start this once some PRs land on master, but I figure this might actually finish before then and doesn't seem bad to get it going just to have some additional preliminary results. It'll also give us an opportunity to write up the necessary scripts to parse out the logs and analyze the data across a couple thousand crates (which we don't yet have the data for anywhere).

@craterbot
Copy link
Collaborator

👌 Experiment pr-87066-3 created and queued.
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🚧 Experiment pr-87066-3 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 18, 2021
@craterbot
Copy link
Collaborator

🎉 Experiment pr-87066-3 is completed!
📊 328 regressed and 408 fixed (10000 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Aug 18, 2021
This was referenced Aug 19, 2021
Merged
Merged
@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 19, 2021
@JohnCSimon JohnCSimon added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@arora-aman @rust-highfive @Mark-Simulacrum @bors @craterbot @davidtwco @JohnCSimon