Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc: Move label to symbol #86594

Merged
merged 2 commits into from
Jun 29, 2021
Merged

rustdoc: Move label to symbol #86594

merged 2 commits into from
Jun 29, 2021

Conversation

dns2utf8
Copy link
Contributor

@dns2utf8 dns2utf8 commented Jun 24, 2021 •
edited
Loading

Implements #86578 depends on #85651

r? @GuillaumeGomez

Screenshot of mobile

grafik

Screenshot on desktop

grafik

@JohnTitor JohnTitor added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 24, 2021
@dns2utf8
Copy link
Contributor Author

Thanks! Bors seems to be busy.

@dns2utf8
Copy link
Contributor Author

I uploaded a demo for the PR: https://data.estada.ch/rustdoc-nightly_2336406b38_2021-06-24/rustdoc_demo/mod1/index.html

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Jun 24, 2021

☔ The latest upstream changes (presumably #85651) made this pull request unmergeable. Please resolve the merge conflicts.

@dns2utf8 dns2utf8 force-pushed the move_label_to_symbol branch from f15ff16 to 3484631 Compare June 25, 2021 08:32
@dns2utf8
Copy link
Contributor Author

During testing I noticed that rustdoc-gui tests were running sequentially taking ~40 seconds to complete.
Now the run in parallel and take ~9 seconds 🥳

@dns2utf8 dns2utf8 mentioned this pull request Jun 25, 2021
Closed
@dns2utf8
Copy link
Contributor Author

I hid the passing tests and only show the failed ones in alphabetical order:
image

@GuillaumeGomez
Copy link
Member

Still: please move the runner changes into another PR so I can already merge the fixes? :)

We can debate more at ease on another 100%-focused PR about this.

@dns2utf8
Copy link
Contributor Author

ah, overlooked that 😅 let me reorganise it

@dns2utf8 dns2utf8 force-pushed the move_label_to_symbol branch from 3abca47 to 0f3ea4d Compare June 28, 2021 15:43
@dns2utf8 dns2utf8 mentioned this pull request Jun 28, 2021
Merged
@dns2utf8 dns2utf8 force-pushed the move_label_to_symbol branch from 1864997 to 84374ed Compare June 28, 2021 16:17
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@dns2utf8 dns2utf8 force-pushed the move_label_to_symbol branch from 84374ed to 0f2e137 Compare June 28, 2021 19:46
@GuillaumeGomez
Copy link
Member

Thanks!

@bors: r+

@bors
Copy link
Contributor

bors commented Jun 29, 2021

📌 Commit 0f2e137 has been approved by GuillaumeGomez

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 29, 2021
@dns2utf8
Copy link
Contributor Author

You are welcome! 🥳

@bors
Copy link
Contributor

bors commented Jun 29, 2021

⌛ Testing commit 0f2e137 with merge 5d0fae5...

@bors
Copy link
Contributor

bors commented Jun 29, 2021

☀️ Test successful - checks-actions
Approved by: GuillaumeGomez
Pushing 5d0fae5 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 29, 2021
@bors bors merged commit 5d0fae5 into rust-lang:master Jun 29, 2021
@rustbot rustbot added this to the 1.55.0 milestone Jun 29, 2021
@dns2utf8 dns2utf8 deleted the move_label_to_symbol branch June 29, 2021 15:16
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jun 30, 2021
Merged
@dns2utf8 dns2utf8 mentioned this pull request Jun 30, 2021
Open
dns2utf8 added a commit to dns2utf8/rust that referenced this pull request Jul 1, 2021
@dns2utf8
Enable the tests developed with rust-lang#86594
3645851
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jul 1, 2021
@GuillaumeGomez
Rollup merge of rust-lang#86773 - dns2utf8:rustdoc_enable_near_tests,…
d10af08 
… r=GuillaumeGomez

Enable the tests developed with rust-lang#86594

This PR requires `[email protected]`. Can we centralise the version number somehow and maybe automatically install it when tests are run?

r? `@GuillaumeGomez`
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jul 1, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 1, 2021
@bors
Auto merge of rust-lang#86774 - GuillaumeGomez:rollup-rkcgvph, r=Guil…
3cb1c11 
…laumeGomez

Rollup of 6 pull requests

Successful merges:

 - rust-lang#86558 (Add suggestions for "undefined reference" link errors)
 - rust-lang#86616 (rustc_span: Explicitly handle crates that differ from package names)
 - rust-lang#86652 (Add support for leaf function frame pointer elimination)
 - rust-lang#86666 (Fix misleading "impl Trait" error)
 - rust-lang#86762 (mailmap: Add my work email address)
 - rust-lang#86773 (Enable the tests developed with rust-lang#86594)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@dns2utf8 dns2utf8 mentioned this pull request Jul 1, 2021
Closed
@jsha jsha mentioned this pull request Jun 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees

@GuillaumeGomez GuillaumeGomez

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.55.0
Development

Successfully merging this pull request may close these issues.
6 participants
@dns2utf8 @rust-log-analyzer @bors @GuillaumeGomez @JohnTitor @rustbot