-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update RELEASES.md with missing deprecation notes. #84914
Conversation
(rust-highfive has picked a reviewer for you, use r? to override) |
|
I don't know how complete the compatibility notes section is supposed to be, if any of these were intentionally omitted let me know. |
It probably makes sense to target master for this PR, as we try to keep the stable branch updated to the release and not some delta thereof. I don't think we expect to rebuild artifacts at this point. I don't think compat notes is the right section for this, though, as these aren't breaking changes or even changes users should expect to need to change away from, just that it may be desirable. I don't think we generally include notes on all deprecations. |
@@ -97,6 +97,9 @@ Compatibility Notes | |||
- [Rustc now catches more cases of `pub_use_of_private_extern_crate`][80763] | |||
- [Changes in how proc macros handle whitespace may lead to panics when used | |||
with older `proc-macro-hack` versions. A `cargo update` should be sufficient to fix this in all cases.][84136] | |||
- [Deprecated internal compiler derive macros `RustcEncodable` and `RustcDecodable`.][83160] | |||
- [Deprecated `alloc::LayoutErr` in favor of `alloc::LayoutError`.][81767] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked through the earlier compatibility notes, sometimes deprecation is mentioned under "compatibility notes", sometimes under "library", and indeed most of the time not at all. The deprecations that are mentioned are generally changes that affect a large number of users, such as |
Yeah, I think I'm going to go ahead and give this a close. I don't think these deprecations necessarily qualify and any affected users will directly be told by the compiler regardless. |
Thanks! |
I don't have an opinion on their inclusion. Though I do think we should try and occasionally remind people about the @CDirkx Thank you for your PR! |
Adds the following missing deprecation notes for the 1.52.0 release:
RustcEncodable
,RustcDecodable
(Deprecate RustcEncodable and RustcDecodable. #83160)alloc::LayoutErr
(Update LayoutError/LayoutErr stability attributes #81767)intrinsics::drop_in_place
andcollections::Bound
(Deprecateintrinsics::drop_in_place
andcollections::Bound
, which accidentally weren't deprecated #82122)