Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement setting thread name for Fuchsia #84589

Merged
merged 2 commits into from
Jul 24, 2021
Merged

Implement setting thread name for Fuchsia #84589

merged 2 commits into from
Jul 24, 2021

Conversation

In-line
Copy link
Contributor

@In-line In-line commented Apr 26, 2021

No description provided.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @joshtriplett (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 26, 2021
@joshtriplett joshtriplett mentioned this pull request Apr 29, 2021
Closed
@crlf0710 crlf0710 added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. O-fuchsia Operating system: Fuchsia and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 15, 2021
@JohnCSimon JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 31, 2021
@JohnTitor JohnTitor added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 2, 2021
@JohnCSimon
Copy link
Member

Ping from triage:
@In-line - can you please address the comments from the reviewer?

@In-line
Copy link
Contributor Author

In-line commented Jul 18, 2021 via email •
edited
Loading

@JohnTitor
Copy link
Member

The implementation looks good to me.
r? @JohnTitor @bors r+

@bors
Copy link
Contributor

bors commented Jul 23, 2021

📌 Commit 2ac0b3e has been approved by JohnTitor

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 23, 2021
@bors
Copy link
Contributor

bors commented Jul 24, 2021

⌛ Testing commit 2ac0b3e with merge 1c66d11...

@bors
Copy link
Contributor

bors commented Jul 24, 2021

☀️ Test successful - checks-actions
Approved by: JohnTitor
Pushing 1c66d11 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 24, 2021
@bors bors merged commit 1c66d11 into rust-lang:master Jul 24, 2021
@rustbot rustbot added this to the 1.56.0 milestone Jul 24, 2021
@matthiaskrgr matthiaskrgr mentioned this pull request Sep 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyn514 jyn514 jyn514 left review comments

@JohnTitor JohnTitor JohnTitor approved these changes

Assignees

@JohnTitor JohnTitor

Labels
merged-by-bors This PR was explicitly merged by bors. O-fuchsia Operating system: Fuchsia S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.56.0
Development

Successfully merging this pull request may close these issues.
9 participants
@In-line @rust-highfive @JohnCSimon @JohnTitor @bors @jyn514 @joshtriplett @crlf0710 @rustbot