Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce python3 and deprecate the use of python2 #82433

Closed

Conversation

henryboisdequin
Copy link
Contributor

This PR enforces python3 and depreciates the use of python2 to build the Rust compiler. As python2 is no longer supported and we are approaching python4, we should move towards python3. Python2 is no longer maintained and could bring bugs to rustc if used. Even though Rust is about compatibility, the Python team highly recommends deprecating python2 since it's no longer maintained and security/general bug reports will not be looked at. Additionally, if rustc wanted to use python3 only features/python3 only packages, this would break when using python2.

Note: this PR also formats the Python code

From the Python "Sunset Python 2" blog post:

What will happen if I did not upgrade by January 1st, 2020?

If people find catastrophic security problems in Python 2, or in software written in Python 2, then most volunteers will not help fix them. If you need help with Python 2 software, then many volunteers will not help you, and over time fewer and fewer volunteers will be able to help you. You will lose chances to use good tools because they will only run on Python 3, and you will slow down people who depend on you and work with you.
Some of these problems started on January 1. Other problems will grow over time.

@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 23, 2021
@jyn514
Copy link
Member

jyn514 commented Feb 23, 2021

Please see #71818 (comment); I don't think this is the sort of change that should be made with a PR out of the blue.

@henryboisdequin
Copy link
Contributor Author

@jyn514 I agree, I didn't see that comment. I will close this PR and follow up on Zulip.

@jyn514 jyn514 changed the title Enforce python3 and depreciates the use of python2 Enforce python3 and deprecate the use of python2 Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants