Check for rmeta crates when getting existing crates from cache #81414
Conversation
|
r? @lcnr (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
does running perf matter here? considering that we don't have any perf runs using windows? |
|
@lcnr this should affect all platforms since rmeta files are used on all platforms. Though I would hope this would largely be positive. |
|
also I don't know enough about this to tell if this change is good 😅 maybe |
|
@bors try @rust-timer queue |
|
Awaiting bors try build completion. |
|
⌛ Trying commit 36835b7 with merge 0c36e818d2ad0e7c12c23b7eb92dc6a03b16dab7... |
|
☀️ Try build successful - checks-actions |
|
Queued 0c36e818d2ad0e7c12c23b7eb92dc6a03b16dab7 with parent 7907345, future comparison URL. @rustbot label: +S-waiting-on-perf |
rustbot
added
the
S-waiting-on-perf
|
I'll review this if nobody else gets to this before me. This is really promising. |
There was a problem hiding this comment.
I've reviewed the surrounding code and this change looks good to me in context of it. I see @petrochenkov self-assigned themselves too, so I'll give them an opportunity to review too (not to mention that timing run isn't complete yet).
|
Finished benchmarking try commit (0c36e818d2ad0e7c12c23b7eb92dc6a03b16dab7): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
rustbot
removed
the
S-waiting-on-perf
|
Looks like the perf is largely neutral. This is likely only to have a noticeable impact on extremely large crates. |
|
It is positive for large-ish crate graphs (such as hyper); AFAICT that's the largest crate graph in the list of crates we time. |
|
@bors r+ |
|
📌 Commit 36835b7 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
…trochenkov Pre-canoncalize ExternLocation::ExactPaths This stores pre-canacolized paths inside `ExternLocation::ExactPaths` so that we don't need to canoncalize them every time we want to compare them to source lib paths. This is related to rust-lang#81414.
This change makes sure to check for rmeta files when resolving crates instead of always going to disk in that case.