Hide help button on mobile #77979
Hide help button on mobile #77979
Conversation
|
Some changes occurred in HTML/CSS/JS. |
rust-highfive
added
the
S-waiting-on-review
GuillaumeGomez
force-pushed
the
hide-help-button
branch
from
dea667d to
fce04fe
Compare
GuillaumeGomez
added
A-rustdoc-ui
|
Instead of saying 'fixes' and opening a new issue, can you instead say "addresses" and put more comments on the same issue? That way all the discussion is in one place. |
|
Sure. |
|
Seems reasonable, but I don't know how to test this. Do you have screenshots of what it looks like after? |
|
I added a screenshot. :) |
|
@bors r+ |
|
📌 Commit fce04fe has been approved by |
bors
added
S-waiting-on-bors
|
@bors: rollup |
…laumeGomez Rollup of 3 pull requests Successful merges: - rust-lang#77963 (Fix link to foreign calling conventions) - rust-lang#77978 (Fix typo in documentation) - rust-lang#77979 (Hide help button on mobile) Failed merges: r? `@ghost`
|
@njasm can you open an issue? I agree it's less than ideal, but this PR didn't change very much in that area; it actually made it less crowded because |
|
It's already an existing issue (I'm currently working on it). |
|
@jyn514 yes. my bad. I wanted to comment on another issue, but got lost in the github android app navigation and posted here. PS - I'll delete the comment since it's just bringing noise to this already merged PR. 👍 |
Addresses #77899.
This PR is just a quick fix for now: we're still debating about whether or not we want to display this help popup and if so, how. I'll open an issue once this PR is merged to discuss about it.
Before:
After:
r? @jyn514