Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce unwind invariants #73133

Merged
merged 4 commits into from
Jun 10, 2020
Merged

Enforce unwind invariants #73133

merged 4 commits into from
Jun 10, 2020

Conversation

doctorn
Copy link
Contributor

@doctorn doctorn commented Jun 8, 2020

I had a quick look at #72959. The failure message probably needs to be more detailed but I just wanted to check I got the right idea. I have no idea how to right a test for this either...

r? @jonas-schievink

Resolves #72959 (hypothetically)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 8, 2020
@rust-highfive

This comment has been minimized.

Sign in to view
jonas-schievink
jonas-schievink reviewed Jun 8, 2020
View reviewed changes
Copy link
Contributor

@jonas-schievink jonas-schievink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good! I'll run this with -Zvalidate-mir on the test suite to check if it finds anything. I don't think we need more testing than that (this is only an internal utility pass after all).

@jonas-schievink
Copy link
Contributor

I'll run this with -Zvalidate-mir on the test suite to check if it finds anything.

Oh, right, this doesn't currently work

@jonas-schievink
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jun 9, 2020

📌 Commit 9495ee2 has been approved by jonas-schievink

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 9, 2020
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Jun 9, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 10, 2020
@bors
Auto merge of rust-lang#73190 - Dylan-DPC:rollup-9wbyh4y, r=Dylan-DPC
bb86748 
Rollup of 8 pull requests

Successful merges:

 - rust-lang#72417 (Remove `RawVec::reserve_in_place`.)
 - rust-lang#73098 (Add Item::is_fake for rustdoc)
 - rust-lang#73122 (Resolve E0584 conflict)
 - rust-lang#73123 (Clean up E0647 explanation)
 - rust-lang#73133 (Enforce unwind invariants)
 - rust-lang#73148 (Fix a typo (size of the size))
 - rust-lang#73149 (typo: awailable -> available)
 - rust-lang#73161 (Add mailmap entry)

Failed merges:

r? @ghost
@bors bors merged commit 161a8bf into rust-lang:master Jun 10, 2020
@cuviper cuviper added this to the 1.46 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonas-schievink jonas-schievink jonas-schievink left review comments

Assignees

@jonas-schievink jonas-schievink

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.46
Development

Successfully merging this pull request may close these issues.

-Zvalidate-mir: check that all unwind edges go to cleanup blocks
5 participants
@doctorn @rust-highfive @jonas-schievink @bors @cuviper