Un-ignore rusti/rustpkg tests on x86 #6733
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@catamorphism, not sure why it failed linux the first time, but I slightly tweaked the logic and it passed through linux try just fine, so it may pass this time? |
|
@catamorphism , I think github is switching things up, oddly enough 1ab23ea is the parent of 74508d6, despite what github is showing... |
|
Is bors not seeing this because the parentage is messed up? Perhaps you could squash and push the unified commit. |
|
@bstrie, I think the r+ just needs to be on the other commit |
This way a cross-compiled rustc's answer to host_triple() is correct. The return value of host_triple() reflects the actual host triple that the compiler was build for, not the triple the compiler is being built on
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Feb 25, 2021
Test workspace at once changelog: none Follow-up to rust-lang#6733
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the relevant information can be found in the commit messages.
r? @brson - I just wanted to make sure the make changes aren't completely bogus
This would close #2400, #6517, and #6489 (although a run through incoming-full on linux would have to confirm the latter two)