-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustdoc: general cleanup #63453
Merged
Merged
rustdoc: general cleanup #63453
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
65ea7b7
rustdoc: Replace HirVec with slices in doctree
Mark-Simulacrum 19c85a8
Move def_id_to_path to use site in visit_ast
Mark-Simulacrum 00d7bc7
Remove crate_name from DocContext
Mark-Simulacrum 8f80a8d
Use entry API in store_path
Mark-Simulacrum c574810
Remove ReentrantMutex
Mark-Simulacrum 6be2857
Replace Arc with Rc around external_traits
Mark-Simulacrum 0031951
Store typed Passes
Mark-Simulacrum 0347480
Don't store all traits in DocContext
Mark-Simulacrum eea2f87
Use a HashSet instead of Vec
Mark-Simulacrum ade8b02
Remove unnecessary channel
Mark-Simulacrum dbad77f
Remove thread-local for playground config
Mark-Simulacrum c250b5f
Remove fmt::Display impls on Markdown structs
Mark-Simulacrum 1aa0964
Drop RefCell from IdMap in markdown rendering
Mark-Simulacrum 3b8a24d
Reduce nesting in externalfiles implementation
Mark-Simulacrum File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if this won't remove some auto impl discovering...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is (AFAICT) equivalent because queries once evaluated are always the same, and in this case we don't touch the all_traits vector except on creation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, if tests pass then I guess nothing changed in the trait discovery so that's all good.