Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect fn with a body in an extern block #62670

Merged
merged 2 commits into from
Jul 15, 2019

Conversation

estebank
Copy link
Contributor

Fix #62109.

@rust-highfive
Copy link
Collaborator

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 14, 2019
@estebank
Copy link
Contributor Author

r? @petrochenkov cc @Centril

@rust-highfive rust-highfive assigned petrochenkov and unassigned eddyb Jul 14, 2019
@rust-highfive

This comment has been minimized.

@estebank estebank force-pushed the extern-fn-with-body branch from 62f3bb0 to f2a6a4e Compare July 14, 2019 05:25
@petrochenkov
Copy link
Contributor

petrochenkov commented Jul 14, 2019

This should be a semantic error eventually (#48137).

@bors
Copy link
Contributor

bors commented Jul 14, 2019

📌 Commit f2a6a4e has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 14, 2019
@bors
Copy link
Contributor

bors commented Jul 15, 2019

⌛ Testing commit f2a6a4e with merge e452e29...

bors added a commit that referenced this pull request Jul 15, 2019
Detect `fn` with a body in an `extern` block

Fix #62109.
@bors
Copy link
Contributor

bors commented Jul 15, 2019

☀️ Test successful - checks-azure, checks-travis, status-appveyor
Approved by: petrochenkov
Pushing e452e29 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 15, 2019
@bors bors merged commit f2a6a4e into rust-lang:master Jul 15, 2019
@estebank estebank deleted the extern-fn-with-body branch November 9, 2023 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confusing error message when trying to implement a function in an extern block
6 participants