More questionmarks in doctests #62663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
Ping from triage, any updates? @QuietMisdreavus |
|
Just trying stuff. |
|
Even more highfive testing. |
|
Hopefully the last test! Sorry for hijacking this PR. |
| /// fn main() -> Result<(), Box<dyn std::error::Error>> { | ||
| /// let mut s = String::new(); | ||
| /// let mut v = Vec::new(); | ||
| /// writeln!(&mut s, "{} {}", "abc", 123)?; // uses fmt::Write::write_fmt |
There was a problem hiding this comment.
Old C habit but maybe add an empty line before this one? Totally not mandatory but I think it'd make the reading a bit easier.
|
r=me once comment addressed (same if you prefer not to address it haha). |
llogiq
force-pushed
the
more-questionmark-docs
branch
from
862512c to
cbac781
Compare
|
@GuillaumeGomez adressed the comment (I also found a second instance). |
|
Thanks! @bors: r+ rollup |
|
📌 Commit cbac781 has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Aug 2, 2019
…illaumeGomez
More questionmarks in doctests
This removes the other `unwrap`s in the macro doctests, replacing them with `?`. For now, we need to specify the main function including the return type, we can get rid of that once the return type suggestion for `fn main() { .. }` works correctly.
r? @QuietMisdreavus
bors
added a commit
that referenced
this pull request
Aug 2, 2019
Rollup of 7 pull requests Successful merges: - #62663 (More questionmarks in doctests) - #62969 (Changing the structure of `mir::interpret::InterpError`) - #63153 (Remove redundant method with const variable resolution) - #63189 (Doc improvements) - #63198 (Allow trailing comma in macro 2.0 declarations.) - #63202 (Fix ICE in #63135) - #63203 (Make is_mutable use PlaceRef instead of it's fields) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the other
unwraps in the macro doctests, replacing them with?. For now, we need to specify the main function including the return type, we can get rid of that once the return type suggestion forfn main() { .. }works correctly.r? @QuietMisdreavus