Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generic const order display in rustdoc #61469

Conversation

GuillaumeGomez
Copy link
Member

Fixes #61292.

r? @varkor

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 2, 2019
@varkor
Copy link
Member

varkor commented Jun 2, 2019

This corrects the order in rustdoc, but what is the underlying order in rustc? Is the reason the parameters aren't in the correct order a problem before it gets to rustdoc at all? If so, we should fix it at an earlier point.

@varkor varkor added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 3, 2019
@GuillaumeGomez
Copy link
Member Author

I'm not completely sure about it. Also, is the generic parameters order important for rust internals? I'll check if it comes from rustdoc but I think it comes from the internals. If so, I'll just update the internals directly.

@varkor
Copy link
Member

varkor commented Jun 3, 2019

At the moment, the internal order is important, though eventually we'd like to change this: #61334. I think rustdoc should be faithful to the internals, so that's where we should fix the issue if that's where it's originating.

@GuillaumeGomez
Copy link
Member Author

Update: Still need to look into the internals.

@joelpalmer
Copy link

Hi @GuillaumeGomez, this is a ping from Triage. Please provide an update on this PR at your earliest convenience.

@GuillaumeGomez
Copy link
Member Author

Still need to start digging in the compiler. Not much time currently though.

@varkor
Copy link
Member

varkor commented Jul 29, 2019

Maybe it'd be worth closing this pull request, as a proper fix is going to look quite different anyway.

@GuillaumeGomez
Copy link
Member Author

Indeed. Let's close it then!

@GuillaumeGomez GuillaumeGomez deleted the fix-const-generic-display-order branch August 19, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Send/Sync type parameters come after const parameters in docs
4 participants